Fix some deprecation issues, add support for DNS URI records #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ipaserver.install.installutils version is deprecated freeipa#221 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Loosely based on ipa commit 49e643783d22ded7a44d84599020af4e8a3d4d5a freeipa#221 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
URI records are not required but if they exist they are validated. freeipa#222 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
rcritten
force-pushed
the
issue_221
branch
2 times, most recently
from
33310b3
to
e39cdd1
Compare
This is mostly from the freeip commit eefbe8558b25ca9e9da10b391ec41e2987b8bd2d Also fix a few legitimate issues the newer pylint uncovered. Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of deprecation warnings coming from IPA and python3-dns.
Also add support for DNS URI records. If the underlying IPA during the test execution contains support for URI records but that support isn't built into healthcheck then some tests will fail and output like this will be seen:
ERROR root:idns.py:73 Unhandled rdtype 256
ERROR root:idns.py:73 Unhandled rdtype 256
ERROR root:idns.py:73 Unhandled rdtype 256
ERROR root:idns.py:73 Unhandled rdtype 256
ERROR root:idns.py:73 Unhandled rdtype 256
ERROR root:idns.py:73 Unhandled rdtype 256
ERROR root:idns.py:73 Unhandled rdtype 256
ERROR root:idns.py:73 Unhandled rdtype 256
rdtype 256 == URI
So do this as an all-in-one shot since the DNS changes are related.