fixups for skipping the pki healthchecks #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping the pki plugins was dependent upon the order the registry was being processed. The assumption was that the ipa plugin would be done first so ca_configured would be defined. If this isn't the case the the pki plugins are incorrectly skipped. So run through the list twice (it's short). Signed-off-by: Rob Crittenden <rcritten@redhat.com> freeipa#201
python3-libsss_nss_idmap isn't required but if it is not present then the asumption is that trust is not available. This code was executing prior to collecting the ca_configured status so if the package was not installed then ca_configured could never be True. Signed-off-by: Rob Crittenden <rcritten@redhat.com> freeipa#201
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pki healthchecks spew a lot of errors if a CA is not configured rather than gracefully reporting nothing.
A few corner cases in healthcheck skipping those were discovered and (hopefully) addressed.