Allow multiple file modes in the FileChecker #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed lint issue: use-a-generator |
flo-renaud
reviewed
Apr 6, 2022
There was a problem hiding this comment.
@rcritten thanks for the PR, LGTM.
I just have one comment re. the tests: the PR adds a new file to test (with a tuple of possible modes), but there's no assert related to this new file. I would expect something like
assert my_results.results[4].result == ...
assert.my_results.results[4].kw.get('msg') == ...
in the test_files_mode method.
There are some cases where a strict file mode is not necessary. The kadmind.log is one. It is owned root:root so there is no real difference between 0600 and 0640. So allow both. https://bugzilla.redhat.com/show_bug.cgi?id=2058239 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
flo-renaud
approved these changes
Apr 6, 2022
| 0640 = 33184 | ||
| 0644 = 33188 | ||
| 0660 = 33200 | ||
| 0666 = 33206 |
There was a problem hiding this comment.
You have no idea how thankful I am for these lines! I'm sure I would have forgotten how to map things over the night :)
There was a problem hiding this comment.
:-)
thanks for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases where a strict file mode is not
necessary. The kadmind.log is one.
It is owned root:root so there is no real difference
between 0600 and 0640. So allow both.
https://bugzilla.redhat.com/show_bug.cgi?id=2058239
Signed-off-by: Rob Crittenden rcritten@redhat.com