Verify that the number of KDC workers matches the CPUs #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-renaud
reviewed
May 3, 2022
There was a problem hiding this comment.
Hi @rcritten
thanks for the PR. Please find an inline comment.
Maximizing the number of workers improves scalability. Particularly in VM environments the number can change over time. The value is set at installation time but could change later. Warn if they values don't match. freeipa#258 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
flo-renaud
approved these changes
May 4, 2022
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maximizing the number of workers improves scalability.
Particularly in VM environments the number can change over
time. The value is set at installation time but could change
later. Warn if they values don't match.
#258
Signed-off-by: Rob Crittenden rcritten@redhat.com