Add more services to check the status, switch to using roles #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some services aren't included in ipaplaform.knownservices like smb and winbind. It is possible to discover the service name using the same method used by ipactl, via roles. Switch some services to the roles method. The services added: * ods_enforcerd * ipa_ods_exporter * ipa_dnskeysyncd * chronyd * smb * winbind Add option to skip disabled services. This is currently only for chronyd which is not required but we'll check it if its enabled. Fixes: freeipa#219 Fixes: freeipa#196 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services aren't included in ipaplaform.knownservices
like smb and winbind. It is possible to discover the
service name using the same method used by ipactl, via roles.
Switch some services to the roles method.
The services added:
Add option to skip disabled services. This is currently only
for chronyd which is not required but we'll check it if its
enabled.
Fixes: #219
Fixes: #196
Signed-off-by: Rob Crittenden rcritten@redhat.com