Report when all ipa-ca records are missing in IPADNSSystemRecordsCheck #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no DNS records were returned at all then the check for mismatches was missed. Add a special case for this scenario by using a placeholder for the IP address for a given CA server. If no records are returned at all this case will catch it. If any exist at all then the current code will handle it. This is is easily reproduced using a non-IPA DNS server like Google or Cloudflare where all lookups will fail. Fixes: freeipa#284 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
f-trivino
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Hi @rcritten,
I tested the code and worksforme, I installed ipa-server without DNS and pointed nameserver to 8.8.8.8, then after running ipa-healthcheck with your code I do see:
{
"source": "ipahealthcheck.ipa.idns",
"check": "IPADNSSystemRecordsCheck",
"result": "WARNING",
"uuid": "968839f8-aff6-41c5-90f8-fc35c6b43712",
"when": "20230411122848Z",
"duration": "96.235592",
"kw": {
"key": "ipa_ca_missing_master.testrealm.test",
"server": "master.testrealm.test",
"msg": "missing IP address for ipa-ca server {server}"
}
}
]
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no DNS records were returned at all then the check for mismatches was missed. Add a special case for this scenario by using a placeholder for the IP address for a given CA server. If no records are returned at all this case will catch it. If any exist at all then the current code will handle it.
This is is easily reproduced using a non-IPA DNS server like Google or Cloudflare where all lookups will fail.
Fixes: #284