If there are KRAs, ensure the renewal server is one #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcritten
force-pushed
the
issue_125
branch
2 times, most recently
from
ba79783
to
6724bf0
Compare
flo-renaud
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Hi @rcritten
Thanks for the PR. The new check works as expected, but I was wondering why it's performing a search to find the KRAs. The call to config_show already gathers all the needed information:
# ipa config-show
[...]
IPA CA renewal master: server.ipa.test
IPA KRA servers: replica.ipa.test
[...]
Any reason to not rely on this info?
If there are KRAs in the topology and there isn't one on the renewal server then the KRA certificates will not be renewed because they expect another server to do it for them. Fixes: freeipa#125 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
No, I totally missed this. Dropped the search as it is much simpler code. |
|
Thanks for the update, LGTM. I tested the same scenario as the pytest:
|
flo-renaud
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are KRAs in the topology and there isn't one on the renewal server then the KRA certificates will not be renewed because they expect another server to do it for them.
Fixes: #125