Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow URLs in usernames or regular names #342

Open
mlissner opened this issue Aug 3, 2023 · 1 comment
Open

Don't allow URLs in usernames or regular names #342

mlissner opened this issue Aug 3, 2023 · 1 comment

Comments

@mlissner
Copy link
Member

mlissner commented Aug 3, 2023

A security researcher found that they can send emails like this one:

image

The way to do so is to put your username as www.evil.com. We should add some checks to make sure people don't do that. This also probably applies to CourtListener, and if we want to have some real fun, we could probably add it to Django as well.

The impact of this is really low, because users are super unlikely to click such a link, but it's worth fixing, sure, why not.

@mlissner
Copy link
Member Author

mlissner commented Aug 3, 2023

I filed an issue in Django too: https://code.djangoproject.com/ticket/34763#ticket

If folks there want this upstream, let's just do that instead of fixing it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant