Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow email address to be same as password #1501

Closed
mlissner opened this issue Dec 15, 2020 · 0 comments
Closed

Don't allow email address to be same as password #1501

mlissner opened this issue Dec 15, 2020 · 0 comments
Assignees

Comments

@mlissner
Copy link
Member

We're now using Django's UserAttributeSimilarityValidator, which is great, but it has a bug that allows people to create passwords that are the same as their username. This was fixed upstream in Django, here:

https://github.com/django/django/pull/8408/files

According to the issue, here:

https://code.djangoproject.com/ticket/28127

We could fix this the hard way, by messing around with the validators, but it seems better to just wait until we upgrade django in #1500. After that, we should check to make sure this is fixed as well.

@mlissner mlissner self-assigned this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant