-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all "optional" attributes getters to OpinionSiteLinear, and correct failing sources #1028
Comments
Solves freelawproject#1028 All updated example files were picking up the "disposition" field, which matches OpinionCluster.disposition . This was not passed to CL, since the getter was not implemented
Solves freelawproject#1028 All updated example files were picking up the "disposition" field, which matches OpinionCluster.disposition . This was not passed to CL, since the getter was not implemented
It may be worth to check freelawproject/courtlistener#4042, maybe we can get rid of some of the unused attributes in this PR |
I found another type of silent failure for
A similar instance is in juriscraper/juriscraper/opinions/united_states/state/mo.py Lines 42 to 43 in 92d2721
I will write a test to catch this problem of unused keys in OpinionSite Linear, and will also correct the straightforward ones |
I have extended
|
Solves freelawproject#1028 - Fixed scrapers: ca7, armfor, haw, mo, tenn, nmariana, virginislands had invalid keys that were not used by any getter, and corrected their example files - extend _check_sanity for OpinionSiteLinear to validate key names - add support for more optional fields: authors, joined_by, per_curiam, Opinion.type
This surfaced on #1020, where the
_get_docket_document_numbers
getter was needed for the new OpinionSiteLinear scraper to keep the old behavior. However, when adding this and other getters to the base OpinionSiteLinear class, it breaks the tests because some fields that were supossed to be scraped, were actually not passed into the scrape caller. They were present onsite.cases[0]
, but not onsite[0]
. With the getter change, theyare now added to the example tests. For example, onfla
and"disposition": disposition.text_content().strip(),
The text was updated successfully, but these errors were encountered: