Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rendererFactory parameter from RendererFragment annotation #257

Closed
gabrielittner opened this issue Dec 15, 2022 · 0 comments · Fixed by #312
Closed

Remove rendererFactory parameter from RendererFragment annotation #257

gabrielittner opened this issue Dec 15, 2022 · 0 comments · Fixed by #312
Labels
c:codegen
Milestone
0.13.0

Comments

@gabrielittner
Copy link
Member

We expect the factory to be a nested class anyways so we can just find it automatically inside the code generator. Either by name or (better) by type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c:codegen
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

automatically find ViewRenderer.Factory instead of requiring a parameter freeletics/khonshu
1 participant
@gabrielittner