Correct use_saved_calibration parameter #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OLD_README.md currently refers to the parameter `use_previous_calibration`, but the correct parameter name is `use_saved_calibration`. This PR changes the existing parameter reference to the correct word, and adds the parameter to the default parameter list. There have been multiple Discord questions around this, so even though this PR will be outdated soon due to the Alpha release, it may save some time while pre-alpha is still in use.
jonmatthis
requested changes
Aug 25, 2022
jonmatthis
approved these changes
Aug 26, 2022
jeff-cn
pushed a commit
to jeff-cn/freemocap
that referenced
this pull request
Nov 23, 2023
OLD_README.md currently refers to the parameter `use_previous_calibration`, but the correct parameter name is `use_saved_calibration`. This PR changes the existing parameter reference to the correct word, and adds the parameter to the default parameter list. There have been multiple Discord questions around this, so even though this PR will be outdated soon due to the Alpha release, it may save some time while pre-alpha is still in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OLD_README.md currently refers to the parameter
use_previous_calibration, but the correct parameter name isuse_saved_calibration. Using the wrong parameter name gives the errorTypeError: RunMe() got an unexpected keyword argument 'use_previous_calibration'. This PR changes the existing parameter reference to the correct word, and adds the parameter to the default parameter list.There have been multiple Discord questions around this, so even though this PR will be outdated soon due to the Alpha release, it may save some time while pre-alpha is still in use.