Trent/better pipedream pings #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmatthis
approved these changes
Mar 28, 2023
jeff-cn
pushed a commit
to jeff-cn/freemocap
that referenced
this pull request
Nov 23, 2023
* w/ jon * getting camera info * changed name of variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a function that gets the number of synchronized videos and the number of frames in each video and puts it in the pinged dictionary as a part of the pipedream pipeline.
I would also like to send along the camera rotations and translation (position) information, which needs to be scraped out of the calibration toml. I'm currently having issues with accessing the correct path to the toml; within RecordingModelInfo, self.calibration_toml_path points to a path that doesn't exist.