Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privacy policy link #357

Merged
merged 5 commits into from Mar 30, 2023
Merged

Add privacy policy link #357

merged 5 commits into from Mar 30, 2023

Conversation

philipqueen
Copy link
Collaborator

Adds a link to the privacy policy under the user pings checkbox and shortens the user pings text.

@trentwirth
Copy link
Collaborator

screenshot for posterity:
image
I think it looks great!

Copy link
Collaborator

@trentwirth trentwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, needs @jonmatthis 's approval now 🚀

@jonmatthis
Copy link
Member

screenshot for posterity: 😞 😢

*screenshot because it's a necessary component of our agreed upon PR workflow 🤩 👍

Copy link
Member

@jonmatthis jonmatthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Make those changes and we're good!

(I'm gonna assume you can click the link and it works ✨ )

freemocap/gui/qt/widgets/home_widget.py Outdated Show resolved Hide resolved
Co-authored-by: jonmatthis <jonmatthis@gmail.com>
@philipqueen
Copy link
Collaborator Author

Committed the requested change, and I can verify clicking the link does work

Copy link
Member

@jonmatthis jonmatthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@philipqueen philipqueen merged commit 7abe611 into main Mar 30, 2023
@philipqueen philipqueen deleted the philip/add-privacy-policy-link branch March 30, 2023 15:40
jeff-cn pushed a commit to jeff-cn/freemocap that referenced this pull request Nov 23, 2023
* Add link to privacy policy under pings checkbox

* Update user pings text and center widget

* Add correct link to privacy policy

* Change ping string per request

Co-authored-by: jonmatthis <jonmatthis@gmail.com>

---------

Co-authored-by: jonmatthis <jonmatthis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants