Support 3.12 #609
Draft
Support 3.12 #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2024
jonmatthis
pushed a commit
to freemocap/skellycam
that referenced
this pull request
Jun 25, 2024
Add support for python 3.12. See freemocap/freemocap#609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for python 3.12.
Why?
We've had an increasing number of users running into problems with trying to install in a python 3.12 environment, unwittingly installing an old release (from before we specified a max version), and getting roundabout errors. Supporting 3.12 will avoid this frequent error.
Why Now?
We were previously blocked by a bug in mediapipe that didn't allow the holistic model to be run on Mac (google-ai-edge/mediapipe#5168). This was fixed in 0.10.13, so we can now bump mediapipe versions and upgrade to supporting 3.12.
Subrepos
All of our subrepos also specify a maximum python version, and these will need to be updated. Currently the PRs just update the maximum version, but we may want to only specify a maximum version in freemocap itself and any suberepo with an explicit conflict, so we don't have to update everywhere every version bump of python.
The following PRs will need to be merged before this one:
freemocap/skellycam#58
freemocap/skellytracker#36
freemocap/skelly_viewer#15
freemocap/skellyforge#4
freemocap/skelly_synchronize#34
freemocap/freemocap_blender_addon#11