tkt#33453 fix AD restart issues #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
william-gr
reviewed
Aug 1, 2018
| @@ -903,7 +903,7 @@ def _started_notify(self, verb, what): | |||
| await self._service("ix-post-samba", "start", quiet=True, **kwargs) | |||
|
|
|||
| async def _started_cifs(self, **kwargs): | |||
| if await self._service("samba_server", "status", quiet=True, onetime=True, **kwargs): | |||
| if await self._service("samba_server", "status", quiet=True, **kwargs): | |||
There was a problem hiding this comment.
This was a changed introduced by me. It serves the purpose to correctly report if samba is running in case "start on boot" is not checked.
This will regress that bit.
jhixson74
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tkt#33453 A few issues discovered during testing