Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tkt-46190: fix(middlewared/logger): do not disable existing loggers #1786

Merged
merged 1 commit into from
Sep 12, 2018
Merged

tkt-46190: fix(middlewared/logger): do not disable existing loggers #1786

merged 1 commit into from
Sep 12, 2018

Conversation

william-gr
Copy link
Member

No description provided.

@ghost ghost assigned william-gr Sep 12, 2018
@ghost ghost added the review label Sep 12, 2018
@bugclerk bugclerk changed the title fix(middlewared/logger): do not disable existing loggers tkt-46190: fix(middlewared/logger): do not disable existing loggers Sep 12, 2018
themylogin
themylogin approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@themylogin themylogin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: what was the undesired behavior that you've get rid of with this patch?

@william-gr
Copy link
Member Author

@themylogin asyncio loggers would not log anything, e.g. asyncio.default_exception_handler

@william-gr william-gr merged commit 0e2e78b into master Sep 12, 2018
@ghost ghost removed the review label Sep 12, 2018
@william-gr william-gr deleted the issues/logging branch September 12, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themylogin themylogin themylogin approved these changes

Assignees

@william-gr william-gr

Labels
jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@william-gr @themylogin