Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkt-67618: Only allow ascii password #2340

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Conversation

william-gr
Copy link
Member

While I'm here also make sure only ValueError is not logged.

Ticket: #67618

@bugclerk bugclerk changed the title fix(middlewared/mail): hide mailconfig password tkt-67618: fix(middlewared/mail): hide mailconfig password Jan 4, 2019
@william-gr william-gr added the WIP label Jan 4, 2019
While I'm here also make sure only ValueError is not logged.

Ticket:	#67618
@william-gr william-gr changed the title tkt-67618: fix(middlewared/mail): hide mailconfig password tkt-67618: Only allow ascii password Jan 7, 2019
wblock
wblock previously requested changes Jan 7, 2019
src/middlewared/middlewared/plugins/mail.py Outdated Show resolved Hide resolved
@william-gr william-gr dismissed wblock’s stale review January 7, 2019 15:08

Review addressed

@william-gr william-gr merged commit 4b376b6 into freenas/11.2-stable Jan 7, 2019
@william-gr william-gr deleted the issues/67618 branch January 7, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants