Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkt-67618: Only allow ascii password #2340

Merged
merged 2 commits into from Jan 7, 2019

Conversation

Projects
None yet
4 participants
@william-gr
Copy link
Member

commented Jan 4, 2019

While I'm here also make sure only ValueError is not logged.

Ticket: #67618

@bugclerk bugclerk changed the title fix(middlewared/mail): hide mailconfig password tkt-67618: fix(middlewared/mail): hide mailconfig password Jan 4, 2019

@william-gr william-gr added the WIP label Jan 4, 2019

fix(middlewared/mail): hide mailconfig password
While I'm here also make sure only ValueError is not logged.

Ticket:	#67618

@william-gr william-gr force-pushed the issues/67618 branch from e9b2290 to d60b3e1 Jan 7, 2019

@william-gr william-gr removed the WIP label Jan 7, 2019

@william-gr william-gr requested a review from wblock Jan 7, 2019

@william-gr william-gr requested a review from sonicaj Jan 7, 2019

@william-gr william-gr changed the title tkt-67618: fix(middlewared/mail): hide mailconfig password tkt-67618: Only allow ascii password Jan 7, 2019

@sonicaj

sonicaj approved these changes Jan 7, 2019

@william-gr william-gr force-pushed the issues/67618 branch from d60b3e1 to 6463826 Jan 7, 2019

Review addressed

@william-gr william-gr merged commit 4b376b6 into freenas/11.2-stable Jan 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bugclerk bugclerk added the backported label Jan 7, 2019

@william-gr william-gr deleted the issues/67618 branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.