-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tkt-74631: FN 12 Installer #2734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit copies the old installer to a new file for FN 12.
This commit removes all usages of legacy avatar file and instead makes use of the manifest file for FN 12.
This commit removes get_product_path usage in critical section of freenas installer.
sonicaj
force-pushed
the
issues/74631
branch
7 times, most recently
from
March 12, 2019 10:47
c509282
to
d5150e9
Compare
This commit makes sure we install base packages before making any changes
This commit explicitly sets automatic flags for base packages.
This commit completes setup env for pkg so we can chroot in /tmp/data and install packages there.
This commit updates FN 12 installer to install FN packages and remove freenas-pkgtools usage
sonicaj
force-pushed
the
issues/74631
branch
2 times, most recently
from
March 12, 2019 13:41
1836ba1
to
b455399
Compare
This commit adds some postinstall commands which should be executed for FN12.
This commit removes portion when we tried to copy /data contents in the chroot env's /data - the new build system currently takes care of that ( we might change that in future to minimalize boot time )
This commit removes /etc/pkg and /dist directory which we mounted to install packages in chroot env.
This commit mounts devfs before we install any packages as we need it for package installation as well.
This commit fixes a bug where commands using redirection operations were not correctly used with chroot.
This commit sets package building variable so that we don't have scripts asking questions.
This commit removes unused variables which were used for installing with freenas-pkgtools.
william-gr
reviewed
Mar 12, 2019
william-gr
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bring in the necessary changes so we use FN installer for FN 12 images.
Ticket: #74631