Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkt-79239: Ensure UPS is not ONLINE at shutdown event #2833

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Apr 3, 2019

This commit ensures UPS is not ONLINE when shutdown event is passed by upssched. There are cases where battery/charger issues can result in ups.status being 'OL LB' at the same time. This will ensure that we don't initiate a shutdown if ups is OL.
Ticket: #79239

@sonicaj sonicaj self-assigned this Apr 3, 2019
@sonicaj sonicaj requested a review from william-gr April 3, 2019 19:34
@bugclerk bugclerk changed the title Ensure UPS is not ONLINE at shutdown event tkt-79239: Ensure UPS is not ONLINE at shutdown event Apr 3, 2019
Copy link
Member

@william-gr william-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lets get Vladimir review as well since he wrote that part.

This commit ensures UPS is not ONLINE when shutdown event is passed by upssched. There are cases where battery/charger issues can result in ups.status being 'OL LB' at the same time. This will ensure that we don't initiate a shutdown if ups is OL.
Ticket: #79239
This commit fixes logging for upssched event in middlewared making sure it correctly logs to messages.
@sonicaj sonicaj requested a review from themylogin April 3, 2019 21:34
@sonicaj sonicaj merged commit 810d28e into master Apr 3, 2019
@sonicaj sonicaj deleted the issues/79239 branch April 3, 2019 21:59
@sonicaj
Copy link
Member Author

sonicaj commented Apr 3, 2019

backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants