Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-109336 / 21.04 / Delete snapshots in descendant filesystems as well on chart release upgrade #6401

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Feb 9, 2021

This PR adds changes to delete snapshots of descendant chart release filesystems as well if they exist with the same name which can happen on failed upgrades.

@sonicaj sonicaj self-assigned this Feb 9, 2021
@bugclerk bugclerk changed the title Delete snapshots in descendant filesystems as well on chart release upgrade NAS-109336 / 21.02 / Delete snapshots in descendant filesystems as well on chart release upgrade Feb 9, 2021
Copy link
Contributor

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean solution! :)

@william-gr william-gr changed the title NAS-109336 / 21.02 / Delete snapshots in descendant filesystems as well on chart release upgrade NAS-109336 / 21.04 / Delete snapshots in descendant filesystems as well on chart release upgrade Feb 16, 2021
@sonicaj sonicaj merged commit e8212f0 into master Feb 16, 2021
@sonicaj sonicaj deleted the snapshot-chart-release-upgrade branch February 16, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants