Upgrade progress support for jails and plugins/basejails #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2018 20:09
- Change pkg variable to unjailed to represent it's actual use - Allow stdin to be used with Exec - Close stdout and stderr in exec, stdin will be closed if specified - Update comment to further clarify intent Ticket: #50167
skarekrow
pushed a commit
to truenas/middleware
that referenced
this pull request
Oct 18, 2018
These two tickets dovetail together, so they're combined into a single PR to reduce unnecessary diffs. Relies on the iocage PR: truenas/iocage#60 - Add a new dict for options - RELEASE is now optional, only if the jail is a Plugin - Add upgrade progress, this changes depending on the type of jail. - Use iocage's lib for this to reduce amount of stale code Ticket: #50167 Ticket: #51863
william-gr
approved these changes
Oct 18, 2018
skarekrow
pushed a commit
to truenas/middleware
that referenced
this pull request
Oct 18, 2018
These two tickets dovetail together, so they're combined into a single PR to reduce unnecessary diffs. Relies on the iocage PR: truenas/iocage#60 - Add a new dict for options - RELEASE is now optional, only if the jail is a Plugin - Add upgrade progress, this changes depending on the type of jail. - Use iocage's lib for this to reduce amount of stale code Ticket: #50167 Ticket: #51863
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iocage side of 50167 and 51863