This repository has been archived by the owner on Feb 11, 2021. It is now read-only.
Allow access to ZFS snapshots over SMB #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grant OSX / Linux clients access to ZFS snapshots. Allow bypassing vfs_shadow_copy2 when needed.
Convert mode->ACL inside zfsacl. This is a better fix rather than just blindly applying "everyone-readonly". Tested against 4.6.8. Patch tweaked a bit to apply to master.
b-a-t
reviewed
Dec 14, 2017
source3/modules/vfs_zfsacl.c
Outdated
| | SMB_ACE4_SYNCHRONIZE; | ||
| uint32_t base_set = SMB_ACE4_READ_NAMED_ATTRS | SMB_ACE4_READ_ATTRIBUTES \ | ||
| | SMB_ACE4_READ_ACL; | ||
|
|
There was a problem hiding this comment.
I'd move those mode definitions outside of the function body. Possibly make macro definitions, like:
#define ZFSACL_MODIFY_SET (SMB_ACE4_READ_DATA | SMB_ACE4_READ_ACL \
| SMB_ACE4_WRITE_DATA | SMB_ACE4_APPEND_DATA | SMB_ACE4_READ_NAMED_ATTRS \
| SMB_ACE4_WRITE_NAMED_ATTRS | SMB_ACE4_EXECUTE | SMB_ACE4_DELETE_CHILD \
| SMB_ACE4_READ_ATTRIBUTES | SMB_ACE4_WRITE_ATTRIBUTES | SMB_ACE4_DELETE \
| SMB_ACE4_SYNCHRONIZE)
Exposing snapdir via SMB requires the parameter: "zfsacl:expose_snapdir = true"
Not everything is true
jhixson74
approved these changes
Jan 9, 2018
|
Jenkins: retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grant OSX / Linux clients access to ZFS snapshots. Allow bypassing vfs_shadow_copy2 when needed.