Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly set cursor focus in shell to true #1249

Merged
merged 1 commit into from
Sep 21, 2018
Merged

explicitly set cursor focus in shell to true #1249

merged 1 commit into from
Sep 21, 2018

Conversation

dkmullen
Copy link
Contributor

Ticket: #43778

@ghost ghost assigned dkmullen Sep 20, 2018
@ghost ghost added the review label Sep 20, 2018
@vaibhav-rbs vaibhav-rbs self-requested a review September 21, 2018 18:12
@vaibhav-rbs
Copy link
Contributor

I think cursor is always in focus, like solid, its not blinking is this behaviour expected ?

@dkmullen
Copy link
Contributor Author

Yes, cursor blink is set to false. I prefer blinking. Also, focus is currently the default behavior anyway, but it produces a warning if you don't set it to true that default will change in the next version.

Copy link
Contributor

@vaibhav-rbs vaibhav-rbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMl sorry I forgot I had to approve that.

@lola27 lola27 merged commit 697b0b2 into master Sep 21, 2018
@ghost ghost removed the review label Sep 21, 2018
@lola27 lola27 deleted the fix-43778 branch September 21, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants