Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add . as valid char for username #1881

Merged
merged 4 commits into from
Feb 25, 2019
Merged

add . as valid char for username #1881

merged 4 commits into from
Feb 25, 2019

Conversation

vaibhav-rbs
Copy link
Contributor

#71281

(cherry picked from commit 260135c)

@vaibhav-rbs
add . as valid char for username
0bfcc42 
#71281

(cherry picked from commit 260135c)
@vaibhav-rbs vaibhav-rbs self-assigned this Feb 7, 2019
erincodepirate
erincodepirate approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@erincodepirate erincodepirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaibhav-rbs
escape \. as part of username regex.
61cb84f 
(cherry picked from commit 743e27a)
@vaibhav-rbs
Copy link
Contributor Author

@Erinix I have applied changes please take a look and approve.

lola27
lola27 approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@lola27 lola27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erincodepirate erincodepirate merged commit 5d4c7dc into master Feb 25, 2019
@erincodepirate erincodepirate deleted the FIX-71281 branch February 25, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erincodepirate erincodepirate erincodepirate approved these changes

@lola27 lola27 lola27 approved these changes

Assignees

@vaibhav-rbs vaibhav-rbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaibhav-rbs @erincodepirate @lola27