Additional Dataset/ZVOL "Advanced Mode" Properties and Replace to new API(Chentao fix 24734)

[Allwithyou999]

https://redmine.ixsystems.com/issues/24734

Done

[amotin]

Just a thought: working on the large project in private branch you could do rebases instead of merges, and/or clean up the commit history a bit before submitting it for public review.

[erincodepirate]

If I try to save a dataset without a quota it tells me "[EFAULT] Failed to create dataset: 'quota' must be a number" it should allow making quota-less datasets

[Allwithyou999]

@Erinix yeah, I will check soon

[Allwithyou999]

@Erinix I double checked but I can't meet your issue.
Did you get this issue in "Add Dataset" or "Edit dataset" page?

[Allwithyou999]

@Erinix And did you upgrade FreeNAS server to the latest version?
If not so, you need to upgrade to the latest version.

[Allwithyou999]

And I found another issue on API side. William said that he would fix it soon.

[erincodepirate]

I may have been using an old version to test against. Let me know when this other API issue is fixed and I will try again

[Allwithyou999]

@Erinix Ok, I will let you know immediately once it is fixed.

[Allwithyou999]

@Erinix API issues were fixed. You can take a test now.

[Allwithyou999]

@Erinix you need to take a test on the latest version(FreeNAS-11-MASTER-201712291544).

[erincodepirate]

LGTM