-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 80922 master #2110
Fix 80922 master #2110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending docs review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small change recommended to the help text.
src/app/helptext/sharing/smb/smb.ts
Outdated
snapshot task to use for the shadow copies of this\ | ||
share. Periodic snapshots must be recursive.'), | ||
placeholder_shadowcopy: T('Enable Shadow Copies'), | ||
tooltip_shadowcopy: T('Export ZFS snapshots as Shadow Copies for VSS clients.'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make "Shadow Copies" in the help text a link to: https://docs.microsoft.com/en-us/windows/desktop/vss/shadow-copies-and-shadow-copy-sets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think the placeholder will be shown to the user, not the actual cifs_shadowcopy name.
rebuild |
Ticket: #80922
Replaces drop-down with checkbox to match MW changes, removes code that is no longer used.