Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 80922 master #2110

Merged
merged 6 commits into from
Mar 30, 2019
Merged

Fix 80922 master #2110

merged 6 commits into from
Mar 30, 2019

Conversation

dkmullen
Copy link
Contributor

Ticket: #80922
Replaces drop-down with checkbox to match MW changes, removes code that is no longer used.

@erincodepirate erincodepirate requested a review from a team March 21, 2019 01:05
Copy link
Contributor

@erincodepirate erincodepirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending docs review

Copy link
Contributor

@Mrt134 Mrt134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small change recommended to the help text.

snapshot task to use for the shadow copies of this\
share. Periodic snapshots must be recursive.'),
placeholder_shadowcopy: T('Enable Shadow Copies'),
tooltip_shadowcopy: T('Export ZFS snapshots as Shadow Copies for VSS clients.'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@wblock wblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the placeholder will be shown to the user, not the actual cifs_shadowcopy name.

@erincodepirate
Copy link
Contributor

rebuild

@erincodepirate erincodepirate merged commit 024e895 into master Mar 30, 2019
@erincodepirate erincodepirate deleted the FIX-80922-master branch March 30, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants