Entity table fixes #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that are single strings.. No spaces. This was not correctly handling the overflow. Fixed... Now string gets cut off appropriately
…style fix .. Just now a class
…... Baiscally.. Just wrapping the my component with a light html component and a this.initialized variable that I set when I have all my rest/websocket data for the drop downs. <div *ngIf=initialized> <entity-form [conf]=this></entity-form> </div> worked really simply without having to pepper a bunch of entity-form plugins.. So cool... This lets me know flexibility in fieldGroup building is possible and simple
…y change.. But sure strange it works in my NPM!!!! those guys need far better cross platform consistency...... CEST LAS VI
…into entity_table_fixes
…k.. geeze... create, delete, clone, rollback that's whats supported old UI used to craete them from the Voumes List page. Ill do so here... But.. Ill put a drop down of existing volumes to create them from
…shots add new button/form
…thod isn't working.. Delete is.. So clone is the finishing next checkin
…c... AND Header column Resize
…. Fixed the No Data Items case wo it has padding.. Also.. Fixed the huge non broken string overflow thing using global stylings we have for ngxTable. Also.. Handle columns with names.. Sizing sorting filtering.. This thing is ready for push request.
psouthwell
requested review from
a user,
erincodepirate,
kmoore134,
lola27 and
dszidi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has
The Add New Snapshot (the old one didn't have the add hooked in).
Added drop down to show this from Snapshots page. The drop down has all the volumes list
Replaced mdTable with ngxDataTable