Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create encrypted UDP transport with streaming and firewall hole-punching #949

Merged
merged 272 commits into from Apr 13, 2024
Merged

Create encrypted UDP transport with streaming and firewall hole-punching #949

merged 272 commits into from Apr 13, 2024

Conversation

sanity
Copy link
Collaborator

@sanity sanity commented Jan 3, 2024

No description provided.

iduartgomez
iduartgomez reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@iduartgomez iduartgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So overall I think the focus of the PR should be establishing and handling a reliable UDP connection and performing the NAT traversal.

Let's leave how those connections are handled to the consumers of the code.

crates/core/Cargo.toml Outdated Show resolved Hide resolved
crates/core/Cargo.toml Outdated Show resolved Hide resolved
crates/core/src/lib.rs Outdated Show resolved Hide resolved
crates/core/src/transport.rs Outdated Show resolved Hide resolved
crates/core/src/transport.rs Outdated Show resolved Hide resolved
crates/core/src/transport.rs Outdated Show resolved Hide resolved
crates/core/src/transport/udp_connection.rs Outdated Show resolved Hide resolved
crates/core/src/transport/udp_transport.rs Outdated Show resolved Hide resolved
crates/core/src/transport/udp_connection.rs Outdated Show resolved Hide resolved
iduartgomez and others added 15 commits March 23, 2024 18:17
@iduartgomez iduartgomez force-pushed the 186770521_port_tahrir_transport_code branch from 7326827 to 0db7b03 Compare April 7, 2024 17:28
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@iduartgomez iduartgomez marked this pull request as ready for review April 13, 2024 20:01
@iduartgomez iduartgomez merged commit d01f814 into main Apr 13, 2024
1 of 6 checks passed
@iduartgomez iduartgomez deleted the 186770521_port_tahrir_transport_code branch April 13, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iduartgomez iduartgomez iduartgomez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sanity @CLAassistant @cheako @iduartgomez @al8n