Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add attribute fileName #17

Merged
merged 4 commits into from
Mar 28, 2024
Merged

feature: Add attribute fileName #17

merged 4 commits into from
Mar 28, 2024

Conversation

wndhydrnt
Copy link
Member

@wndhydrnt wndhydrnt commented Mar 28, 2024

Current implementation creates the name of the file to create by concatenating the attributes application, profile and fileType.
Example:

application: "myapp"
profile: "prod"
fileType: "json"

becomes myapp-prod.json.

This is hard for users to grasp. People often are confused and don't know how to reference the file in the filesystem of a container.

This change adds the attribute fileName and deprecates the attribute fileType.
Users can define the name of the file. However, the extension of the file needs to be supported by Spring Cloud Config Server.
The supported extensions are .yaml, .yml, .json and .properties.

@wndhydrnt wndhydrnt changed the title Add attribute fileName feature: Add attribute fileName Mar 28, 2024
@wndhydrnt wndhydrnt merged commit 49ca421 into master Mar 28, 2024
2 checks passed
@wndhydrnt wndhydrnt deleted the file-name-attribute branch March 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant