Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3 support #48

Merged
merged 12 commits into from Jul 25, 2019
Merged

Add python3 support #48

merged 12 commits into from Jul 25, 2019

Conversation

o01eg
Copy link
Contributor

@o01eg o01eg commented May 9, 2019

This PR is the rebased @adrianbroher python3 branch with python 3.5.7 update and some fixes.

Fixes #47 . Supersedes #50

There both python3.{dll,lib,pdb} and python35.{dll,lib,pdb}. Those libraries are different. Is it intended?

@o01eg o01eg changed the title [WIP] Add python3 support Add python3 support May 9, 2019
@o01eg o01eg changed the title Add python3 support [WIP] Add python3 support May 10, 2019
@adrianbroher
Copy link
Contributor

adrianbroher commented May 10, 2019

There both python3.{dll,lib,pdb} and python35.{dll,lib,pdb}. Those libraries are different. Is it intended?

Probably not, but the used python-cmake is a good mile behind the latest development.

@o01eg
Copy link
Contributor Author

o01eg commented May 11, 2019

Probably not, but the used python-cmake is a good mile behind the latest development.

I've updated python-cmake for latest commit, it successfully builds python but python3.{lib,dll} and python35.{lib,dll} still exists both.

@o01eg
Copy link
Contributor Author

o01eg commented May 11, 2019

Also for both python2 and python3 support boost should be updated to 1.67:

The library name now includes the version suffix of the Python version used to compile it. For example, a variant compiled with Python 2.7 will produce library names boost_python27 and boost_numpy27, etc.. Combined with a related fix in Boost.Build, this means that it is now possible to build variants for multiple Python versions in a single build process.

But I get strange error:

  ...skipped <pbin.v2\libs\log\build\msvc-14.0\rls\adrs-mdl-64\dbg-str-dtbs\dbg-symbl-on\pch-off\thrdp-wn32\thrd-mlt>attribute_name.obj for lack of <pbin.v2\standalone\msvc\msvc-14.0>msvc-setup.nup...

@o01eg
Copy link
Contributor Author

o01eg commented May 12, 2019

If I simply update boost to 1.67 CI only builds boost_python27.{dll,lib}. If I force to build both python with python=2.7 python=3.5 I got errors.

@o01eg o01eg force-pushed the python3 branch 2 times, most recently from b50cad1 to ac7bb50 Compare May 18, 2019 19:28
@o01eg
Copy link
Contributor Author

o01eg commented May 18, 2019

Rebased on top #49 to test with boost 1.68

@o01eg
Copy link
Contributor Author

o01eg commented Jun 9, 2019

Both python support was fixed in 1.70 but there GIL issues to update to this boost version.

@o01eg o01eg changed the title [WIP] Add python3 support Add python3 support Jul 6, 2019
@o01eg
Copy link
Contributor Author

o01eg commented Jul 6, 2019

As freeorion/freeorion#2468 found to be fixed this PR is ready to be merged as well.

@Vezzra
Copy link
Member

Vezzra commented Jul 18, 2019

Anything preventing merge?

@o01eg o01eg mentioned this pull request Jul 18, 2019
@o01eg
Copy link
Contributor Author

o01eg commented Jul 18, 2019

I didn't find issues with this SDK.

@geoffthemedio
Copy link
Member

If you think it's good and no-one objects, then I suggest merging...

@Vezzra Vezzra merged commit b99e0b6 into freeorion:master Jul 25, 2019
@o01eg o01eg deleted the python3 branch July 25, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python3 to Windows and MacOS SDKs
4 participants