New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python3 support #48
Conversation
Probably not, but the used |
I've updated python-cmake for latest commit, it successfully builds python but python3.{lib,dll} and python35.{lib,dll} still exists both. |
Also for both python2 and python3 support boost should be updated to 1.67:
But I get strange error:
|
If I simply update boost to 1.67 CI only builds |
b50cad1
to
ac7bb50
Compare
Rebased on top #49 to test with boost 1.68 |
8d2e98b
to
e43dc4e
Compare
Both python support was fixed in 1.70 but there GIL issues to update to this boost version. |
As freeorion/freeorion#2468 found to be fixed this PR is ready to be merged as well. |
Anything preventing merge? |
I didn't find issues with this SDK. |
If you think it's good and no-one objects, then I suggest merging... |
This PR is the rebased @adrianbroher
python3
branch with python 3.5.7 update and some fixes.Fixes #47 . Supersedes #50
There both
python3.{dll,lib,pdb}
andpython35.{dll,lib,pdb}
. Those libraries are different. Is it intended?