Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong pilot trait weapon damage scaling #3126

Closed
agrrr3 opened this issue Jul 31, 2020 · 5 comments
Closed

Wrong pilot trait weapon damage scaling #3126

agrrr3 opened this issue Jul 31, 2020 · 5 comments
Labels
category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug.
Milestone
v0.4.10.1

Comments

@agrrr3
Copy link
Contributor

agrrr3 commented Jul 31, 2020

It seems the pilot trait effect does not damage-scaled for main line weapons.

forums

Also affects 0.4.10, as we test the scaling in the current slow game sever i would like to have this fix in 0.4.10.1 too
@agrrr3 agrrr3 added the category:bug The Issue/PR describes or solves a perceived malfunction within the game. label Jul 31, 2020
@agrrr3 agrrr3 mentioned this issue Jul 31, 2020
Merged
@agrrr3
Copy link
Contributor Author

agrrr3 commented Jul 31, 2020

stringtables and AI missing

@agrrr3
Copy link
Contributor Author

agrrr3 commented Jul 31, 2020

stringtables dont seem to need to be adjusted. SHP_FIGHTERS_1_DESC already contain the 6-scaled values
AI does not apply scaling to pilot skill yet, so needs adjustment

@geoffthemedio geoffthemedio added this to the v0.4.10.1 milestone Jul 31, 2020
@geoffthemedio geoffthemedio added the component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. label Jul 31, 2020
@agrrr3
Copy link
Contributor Author

agrrr3 commented Aug 2, 2020 •
edited

@o01eg should this go into the slow game?
the implementation is ready - if so it should go there as fast as possible (e.g. before our forces clash). could also have a look at the PR #3127

@o01eg
Copy link
Contributor

o01eg commented Aug 2, 2020

It will break checksum calculation so I cann't apply it on the server without some release.

@agrrr3
Copy link
Contributor Author

agrrr3 commented Aug 2, 2020 via email

@agrrr3 agrrr3 mentioned this issue Aug 3, 2020
Closed
@geoffthemedio geoffthemedio added the status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug. label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug.
Projects
None yet
Milestone
v0.4.10.1
Development

No branches or pull requests
3 participants
@o01eg @agrrr3 @geoffthemedio