Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestEnumParser started to fail #3224

Closed
o01eg opened this issue Nov 8, 2020 · 3 comments
Closed

TestEnumParser started to fail #3224

o01eg opened this issue Nov 8, 2020 · 3 comments
Labels
category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:internal The Issue/PR deals with any project component that has no explicit `component` label. status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug.
Milestone
v0.5

Comments

@o01eg
Copy link
Contributor

o01eg commented Nov 8, 2020 •
edited

Bug Report

Environment

  • FreeOrion Version: 4550078
  • Operating System: Ubuntu Bionic 18.04 (Travis CI)
  • Fetched as
    • Compiled from source

Description

Enum parser test started to fail with errors:

    Start 1: TestEnumParser

1/4 Test #1: TestEnumParser ...................***Failed    0.06 sec

Running 13 test cases...

/home/travis/build/freeorion/freeorion/test/parse/TestEnumParser.cpp:141: error: error: in "TestEnumParser/EmpireAffiliationTypeParser": check pass has failed

/home/travis/build/freeorion/freeorion/test/parse/TestEnumParser.cpp:141: error: error: in "TestEnumParser/EmpireAffiliationTypeParser": check result == EmpireAffiliationType::AFFIL_HUMAN has failed

/home/travis/build/freeorion/freeorion/test/parse/TestEnumParser.cpp:308: error: error: in "TestEnumParser/StatisticTypeParser": check pass has failed

/home/travis/build/freeorion/freeorion/test/parse/TestEnumParser.cpp:308: error: error: in "TestEnumParser/StatisticTypeParser": check result == ValueRef::StatisticType::RMS has failed

*** 4 failures are detected in the test module "FreeOrion unit/coverage tests parser"

Looks like it happened after #3210

Expected Result

CI unittests are passed.

Steps to reproduce

  • Build and run parser unit tests.
@o01eg o01eg added category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:internal The Issue/PR deals with any project component that has no explicit `component` label. priority:high The Issue/PR is very urgent or important and should be addressed/finished as soon as possible. labels Nov 8, 2020
@o01eg o01eg added this to the v0.5 milestone Nov 8, 2020
@geoffthemedio
Copy link
Member

geoffthemedio commented Nov 8, 2020 •
edited

https://github.com/freeorion/freeorion/blob/master/test/parse/TestEnumParser.cpp#L141 should probably pass Human not HUMAN

https://github.com/freeorion/freeorion/blob/master/test/parse/TestEnumParser.cpp#L308 should probably pass RMS not Rms

Trying 2972b56

@o01eg
Copy link
Contributor Author

o01eg commented Nov 8, 2020

@geoffthemedio Yes, it works for me.

@geoffthemedio
Copy link
Member

Should be fixed by 6b359c3

@geoffthemedio geoffthemedio added the status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug. label Nov 8, 2020
@Vezzra Vezzra removed the priority:high The Issue/PR is very urgent or important and should be addressed/finished as soon as possible. label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:internal The Issue/PR deals with any project component that has no explicit `component` label. status:resolved The Issue was resolved, either by answering properly or fixing the underlying bug.
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
3 participants
@o01eg @Vezzra @geoffthemedio