Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empires summary window does not account for Engineering Corps cost #4740

Open
Blue-Award opened this issue Sep 15, 2023 · 8 comments · May be fixed by #4764
Open

Empires summary window does not account for Engineering Corps cost #4740

Blue-Award opened this issue Sep 15, 2023 · 8 comments · May be fixed by #4764
Labels
category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:UI The Issue/PR deals with the game user interface, graphical or other.

Comments

@Blue-Award
Copy link
Contributor

Blue-Award commented Sep 15, 2023

Bug Report

This is on recent builds but probably goes way back. I haven't used Engineering Corps policy in past, but did so in slow MP25 game, so you'll have saves for that (adopted since turn 179)

Basically what the title says. The IP cost on the upper bar correctly shows the expected Influence Points gain for the next turn. However, Empires window summary that shows known start-of-turn values does not account for IP cost of all those ships paying influence points for Engineering Corps

I would expect the Empires summary shows start-of-turn IP gain value including Engineering Corps policy costs
IP view

@Blue-Award Blue-Award added the category:bug The Issue/PR describes or solves a perceived malfunction within the game. label Sep 15, 2023
@Vezzra Vezzra added the component:UI The Issue/PR deals with the game user interface, graphical or other. label Sep 15, 2023
@Blue-Award
Copy link
Contributor Author

Blue-Award commented Sep 15, 2023

Not sure what to do for sensor ghosts of enemy players. Actually does the ship count on the Empires window include ghosts you didn't dismiss? Then probably it's only fair to include them also in IP costs

@geoffthemedio
Copy link
Member

I don't think the tallies for the empires list knows about ghosts or dismissing them.

Otherwise, #4764 might fix it?

@Blue-Award
Copy link
Contributor Author

In MP25 turn 226 (present turn as of writing), without these changes I see 4 IP for myself in the Empires window. With this change, i see -8.3. But I have 92 ships, so it should be -9.2 difference, no? Dunno where do extra 3 IP diff come from.

There are also some slight science point generation differences for some reason

Upper is with this change applied, lower is without. But you know, server doesn't have those changes so... dunno

Resource_gen_tally_226

@Blue-Award
Copy link
Contributor Author

Blue-Award commented Oct 4, 2023

OK so I've added the !this_client_known_destroyed_objects.contains(obj.ID()) && !this_client_stale_object_info.contains(obj.ID()); condition to the mix so those aren't counted (quick and dirty added to owned_by_empire) and it looks better - no changes in science (probably some stale/destroyed data from ships in blizzards?) and IP also more like expected I think? though it's still 8.6 rather than 9.2 but I've noticed monster ships have Influence meter of 0.0 even though Target Influence is -0.1, and I have 6 of them, so it matches that I don't get that extra -0.6 penalty (so, a new bug/issue perhaps, why those monster ships don't change my influence?)

Resource_gen_tally_226

@Blue-Award
Copy link
Contributor Author

so I don't know what those stale data are but it's probably that rather than destroyed, cause I can see destroyed on object list and they don't have science or influence attached. Could prolly attach debugger and confirm it comes from the stale.. or delete just the stale part of condition

@geoffthemedio
Copy link
Member

An option would be to just show the current values of a few empire statistics as calculated on the server for the graphs in the pedia.

@Blue-Award
Copy link
Contributor Author

graphs I think leak total information and are routinely disabled in multiplayer games for that reason, meanwhile "Empires" window is calculated based on what you know, which sounds better (just needs to take stock of this "stale" data issue)

@geoffthemedio
Copy link
Member

Yes, they are different. Using the statistics is still an option, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug The Issue/PR describes or solves a perceived malfunction within the game. component:UI The Issue/PR deals with the game user interface, graphical or other.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants