Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why token digits should only be 6 and 8 #187

Closed
afattahi54 opened this issue Apr 17, 2018 · 2 comments
Closed

Why token digits should only be 6 and 8 #187

afattahi54 opened this issue Apr 17, 2018 · 2 comments

Comments

@afattahi54
Copy link

I found that the Digits should only be 6 and 8.
However I have changed Token.java to accept 7 as Digits.

Every thing is working fine.

Can you please let me know why the Digits should be only 6 or 8.

npmccallum added a commit to npmccallum/freeotp-android that referenced this issue Jul 6, 2018
This commit contains a long-awaited rewrite to address many long-standing
issues. This patch contains:

1. a totally new UI focused on Material Design compliance
2. all tokens are stored in the Android KeyStore
3. support for sending codes over Bluetooth LE to computers via Jelling
4. extensive unit testing
5. expanded branding options (cf. image= and color=)
6. default branding for major issuers (needs docs)
7. sane behavior surrounding the addition of multiple tokens
8. warnings on weak cryptographic parameters
9. token locking (authentication required to get token code)

All this goodness comes with some costs:

1. Android API 23+ is required. This is necessary for KeyStore access.
2. Manual token adding is removed. Use a QR code or click a otpauth:// link.
3. Use of the KeyStore makes token secrets impossible to extract.
4. Tokens are now immutable. Existing changes will be discarded during upgrade.

Closes: freeotp#190
Closes: freeotp#96
Closes: freeotp#78
Closes: freeotp#77
Closes: freeotp#68
Closes: freeotp#55
Closes: freeotp#48
Closes: freeotp#45
Closes: freeotp#43
Closes: freeotp#16
Fixes: freeotp#187
Fixes: freeotp#185
Fixes: freeotp#176
Fixes: freeotp#175
Fixes: freeotp#172
Fixes: freeotp#170
Fixes: freeotp#167
Fixes: freeotp#161
Fixes: freeotp#144
Fixes: freeotp#142
Fixes: freeotp#136
Fixes: freeotp#123
Fixes: freeotp#122
Fixes: freeotp#110
Fixes: freeotp#90
Fixes: freeotp#89
Fixes: freeotp#84
Fixes: freeotp#74
Fixes: freeotp#69
Fixes: freeotp#67
Fixes: freeotp#66
Fixes: freeotp#65
Fixes: freeotp#63
Fixes: freeotp#62
Fixes: freeotp#61
Fixes: freeotp#58
Fixes: freeotp#54
Fixes: freeotp#53
Fixes: freeotp#49
Fixes: freeotp#40
Fixes: freeotp#21
Fixes: freeotp#14
Fixes: freeotp#8
Fixes: freeotp#7
Fixes: freeotp#6
npmccallum added a commit to npmccallum/freeotp-android that referenced this issue Jul 6, 2018
This commit contains a long-awaited rewrite to address many long-standing
issues. This patch contains:

1. a totally new UI focused on Material Design compliance
2. all tokens are stored in the Android KeyStore
3. support for sending codes over Bluetooth LE to computers via Jelling
4. extensive unit testing
5. expanded branding options (cf. image= and color=)
6. default branding for major issuers (needs docs)
7. sane behavior surrounding the addition of multiple tokens
8. warnings on weak cryptographic parameters
9. token locking (authentication required to get token code)

All this goodness comes with some costs:

1. Android API 23+ is required. This is necessary for KeyStore access.
2. Manual token adding is gone. Use a QR code or click a otpauth:// link.
3. Use of the KeyStore makes token secrets impossible to extract.
4. Tokens are immutable. Existing changes will be discarded during upgrade.

Closes: freeotp#190
Closes: freeotp#96
Closes: freeotp#78
Closes: freeotp#77
Closes: freeotp#68
Closes: freeotp#55
Closes: freeotp#48
Closes: freeotp#45
Closes: freeotp#43
Closes: freeotp#16
Fixes: freeotp#187
Fixes: freeotp#185
Fixes: freeotp#176
Fixes: freeotp#175
Fixes: freeotp#172
Fixes: freeotp#170
Fixes: freeotp#167
Fixes: freeotp#161
Fixes: freeotp#144
Fixes: freeotp#142
Fixes: freeotp#136
Fixes: freeotp#123
Fixes: freeotp#122
Fixes: freeotp#110
Fixes: freeotp#90
Fixes: freeotp#89
Fixes: freeotp#84
Fixes: freeotp#74
Fixes: freeotp#69
Fixes: freeotp#67
Fixes: freeotp#66
Fixes: freeotp#65
Fixes: freeotp#63
Fixes: freeotp#62
Fixes: freeotp#61
Fixes: freeotp#58
Fixes: freeotp#54
Fixes: freeotp#53
Fixes: freeotp#49
Fixes: freeotp#40
Fixes: freeotp#21
Fixes: freeotp#14
Fixes: freeotp#8
Fixes: freeotp#7
Fixes: freeotp#6
npmccallum added a commit to npmccallum/freeotp-android that referenced this issue Jul 6, 2018
This commit contains a long-awaited rewrite to address many long-standing
issues. This patch contains:

1. a totally new UI focused on Material Design compliance
2. all tokens are stored in the Android KeyStore
3. support for sending codes over Bluetooth LE to computers via Jelling
4. extensive unit testing
5. expanded branding options (cf. image= and color=)
6. default branding for major issuers (needs docs)
7. sane behavior surrounding the addition of multiple tokens
8. warnings on weak cryptographic parameters
9. token locking (authentication required to get token code)

All this goodness comes with some costs:

1. Android API 23+ is required. This is necessary for KeyStore access.
2. Manual token adding is gone. Use QR code or otpauth:// link.
3. Use of the KeyStore makes token secrets impossible to extract.
4. Tokens are immutable. Existing changes will be discarded on upgrade.

Closes: freeotp#190
Closes: freeotp#96
Closes: freeotp#78
Closes: freeotp#77
Closes: freeotp#68
Closes: freeotp#55
Closes: freeotp#48
Closes: freeotp#45
Closes: freeotp#43
Closes: freeotp#16
Fixes: freeotp#187
Fixes: freeotp#185
Fixes: freeotp#176
Fixes: freeotp#175
Fixes: freeotp#172
Fixes: freeotp#170
Fixes: freeotp#167
Fixes: freeotp#161
Fixes: freeotp#144
Fixes: freeotp#142
Fixes: freeotp#136
Fixes: freeotp#123
Fixes: freeotp#122
Fixes: freeotp#110
Fixes: freeotp#90
Fixes: freeotp#89
Fixes: freeotp#84
Fixes: freeotp#74
Fixes: freeotp#69
Fixes: freeotp#67
Fixes: freeotp#66
Fixes: freeotp#65
Fixes: freeotp#63
Fixes: freeotp#62
Fixes: freeotp#61
Fixes: freeotp#58
Fixes: freeotp#54
Fixes: freeotp#53
Fixes: freeotp#49
Fixes: freeotp#40
Fixes: freeotp#21
Fixes: freeotp#14
Fixes: freeotp#8
Fixes: freeotp#7
Fixes: freeotp#6
npmccallum added a commit to npmccallum/freeotp-android that referenced this issue Jul 6, 2018
This commit contains a long-awaited rewrite to address many long-standing
issues. This patch contains:

1. a totally new UI focused on Material Design compliance
2. all tokens are stored in the Android KeyStore
3. support for sending codes over Bluetooth LE to computers via Jelling
4. extensive unit testing
5. expanded branding options (cf. image= and color=)
6. default branding for major issuers (needs docs)
7. sane behavior surrounding the addition of multiple tokens
8. warnings on weak cryptographic parameters
9. token locking (authentication required to get token code)

All this goodness comes with some costs:

1. Android API 23+ is required. This is necessary for KeyStore access.
2. Manual token adding is gone. Use QR code or otpauth:// link.
3. Use of the KeyStore makes token secrets impossible to extract.
4. Tokens are immutable. Existing changes will be discarded on upgrade.

Closes: freeotp#190
Closes: freeotp#96
Closes: freeotp#78
Closes: freeotp#77
Closes: freeotp#68
Closes: freeotp#55
Closes: freeotp#48
Closes: freeotp#45
Closes: freeotp#43
Closes: freeotp#16
Fixes: freeotp#187
Fixes: freeotp#185
Fixes: freeotp#176
Fixes: freeotp#175
Fixes: freeotp#172
Fixes: freeotp#170
Fixes: freeotp#167
Fixes: freeotp#161
Fixes: freeotp#144
Fixes: freeotp#142
Fixes: freeotp#136
Fixes: freeotp#123
Fixes: freeotp#122
Fixes: freeotp#110
Fixes: freeotp#90
Fixes: freeotp#89
Fixes: freeotp#84
Fixes: freeotp#74
Fixes: freeotp#69
Fixes: freeotp#67
Fixes: freeotp#66
Fixes: freeotp#65
Fixes: freeotp#63
Fixes: freeotp#62
Fixes: freeotp#61
Fixes: freeotp#58
Fixes: freeotp#54
Fixes: freeotp#53
Fixes: freeotp#49
Fixes: freeotp#40
Fixes: freeotp#21
Fixes: freeotp#14
Fixes: freeotp#8
Fixes: freeotp#7
Fixes: freeotp#6
@emericv
Copy link

emericv commented Mar 10, 2019

Impossible to add an OTP with 7 digits... any new on this issue ?

@helloworld1
Copy link

7 digits token was added in the FreeOTP fork https://github.com/helloworld1/FreeOTPPlus/

justin-stephenson pushed a commit to justin-stephenson/freeotp-android that referenced this issue Jan 22, 2021
This commit contains a long-awaited rewrite to address many long-standing
issues. This patch contains:

1. a totally new UI focused on Material Design compliance
2. all tokens are stored in the Android KeyStore
3. support for sending codes over Bluetooth LE to computers via Jelling
4. extensive unit testing
5. expanded branding options (cf. image= and color=)
6. default branding for major issuers (needs docs)
7. sane behavior surrounding the addition of multiple tokens
8. warnings on weak cryptographic parameters
9. token locking (authentication required to get token code)

All this goodness comes with some costs:

1. Android API 23+ is required. This is necessary for KeyStore access.
2. Manual token adding is gone. Use QR code or otpauth:// link.
3. Use of the KeyStore makes token secrets impossible to extract.
4. Tokens are immutable. Existing changes will be discarded on upgrade.

Closes: freeotp#190
Closes: freeotp#96
Closes: freeotp#78
Closes: freeotp#77
Closes: freeotp#68
Closes: freeotp#55
Closes: freeotp#48
Closes: freeotp#45
Closes: freeotp#43
Closes: freeotp#16
Fixes: freeotp#187
Fixes: freeotp#185
Fixes: freeotp#176
Fixes: freeotp#175
Fixes: freeotp#172
Fixes: freeotp#170
Fixes: freeotp#167
Fixes: freeotp#161
Fixes: freeotp#144
Fixes: freeotp#142
Fixes: freeotp#136
Fixes: freeotp#123
Fixes: freeotp#122
Fixes: freeotp#110
Fixes: freeotp#90
Fixes: freeotp#89
Fixes: freeotp#84
Fixes: freeotp#74
Fixes: freeotp#69
Fixes: freeotp#67
Fixes: freeotp#66
Fixes: freeotp#65
Fixes: freeotp#63
Fixes: freeotp#62
Fixes: freeotp#61
Fixes: freeotp#58
Fixes: freeotp#54
Fixes: freeotp#53
Fixes: freeotp#49
Fixes: freeotp#40
Fixes: freeotp#21
Fixes: freeotp#14
Fixes: freeotp#8
Fixes: freeotp#7
Fixes: freeotp#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants