Skip to content

Commit

Permalink
ruby2_keywords is runtime dep not development dep
Browse files Browse the repository at this point in the history
And so should be included as such in the gemspec; not in the Gemfile.

I've specified the '>= 0.0.5' constraint, because v0.0.5 is the version
we've been testing with.

I've used a '>=' constraint rather than a twiddle-wakka ('~> 0.0.5'),
because that's equivalent to the combination of '>= 0.0.5' and '< 0.1.0'
which seems a bit too restrictive. At the moment there's no reason to
suppose later versions of ruby2_keywords won't work with Mocha and we
can always add a constraint later if it turns out there is a problem.

Closes #581.
  • Loading branch information
floehopper committed Nov 3, 2022
1 parent c5cf324 commit cdeb035
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 0 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,3 @@ if ENV['MOCHA_GENERATE_DOCS']
gem 'redcarpet'
gem 'yard'
end

gem 'ruby2_keywords', '~> 0.0.5'
2 changes: 2 additions & 0 deletions mocha.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,6 @@ Gem::Specification.new do |s|
s.homepage = 'https://mocha.jamesmead.org'
s.require_paths = ['lib']
s.summary = 'Mocking and stubbing library'

s.add_runtime_dependency 'ruby2_keywords', '>= 0.0.5'
end

0 comments on commit cdeb035

Please sign in to comment.