Safer method visibility restoration #141

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@tmm1
Contributor

tmm1 commented Mar 1, 2013

This fixes errors when public or private is redefined, for example as a named_scope on an ActiveRecord model.

/cc @floehopper #109

@floehopper

This comment has been minimized.

Show comment
Hide comment
@floehopper

floehopper Mar 2, 2013

Member

Thanks for taking the time to submit these changes. Can you add one or more tests which fail without this change. I think that would help explain why the change is needed.

Member

floehopper commented Mar 2, 2013

Thanks for taking the time to submit these changes. Can you add one or more tests which fail without this change. I think that would help explain why the change is needed.

@ghost ghost assigned floehopper Mar 6, 2013

@floehopper floehopper closed this in 2b3148c Mar 6, 2013

@floehopper

This comment has been minimized.

Show comment
Hide comment
@floehopper

floehopper Mar 6, 2013

Member

Thanks. I merged and amended your commit to include some tests. It would be great if you could check that you're happy with the changes I've made.

Member

floehopper commented Mar 6, 2013

Thanks. I merged and amended your commit to include some tests. It would be great if you could check that you're happy with the changes I've made.

@tmm1

This comment has been minimized.

Show comment
Hide comment
@tmm1

tmm1 Mar 6, 2013

Contributor

Looks great, thanks!

Contributor

tmm1 commented Mar 6, 2013

Looks great, thanks!

@floehopper

This comment has been minimized.

Show comment
Hide comment
@floehopper

floehopper Mar 7, 2013

Member

This has now been released in Mocha 0.13.3. It would be great if you could check that it solves your problem.

Member

floehopper commented Mar 7, 2013

This has now been released in Mocha 0.13.3. It would be great if you could check that it solves your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment