Simplify storage of MOCHA_OPTIONS #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has only ever supported `debug`, `verbose` & `skip_integration` options. However, it currently only supports `debug`. Storing these options in a Hash was always a bit over the top and since it was the only reason we needed to disabled the Style/EachWithObject Rubocop rule, it seems more sensible to use an Array instead. I don't think that the "uniqueness" of the options in the comma-separated list was ever a motivation for storing them in a Hash and so an Array (rather than a Set) seems good enough.
|
This was released in v2.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has only ever supported
debug,verbose&skip_integrationoptions. However, it currently only supportsdebug.Storing these options in a
Hashwas always a bit over the top and since it was the only reason we needed to disabled theStyle/EachWithObjectRubocop rule, it seems more sensible to use anArrayinstead.I don't think that the "uniqueness" of the options in the comma-separated list was ever a motivation for storing them in a
Hashand so anArray(rather than aSet) seems good enough.Supersedes #599.