Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PropTypes from React.PropTypes #3

Merged
merged 1 commit into from
Nov 5, 2017

Conversation

justinchen
Copy link
Contributor

React 16 moved PropTypes to a standalone library. This commit adds the package and changes calls to React.PropTypes to PropTypes.

@freeranger
Copy link
Owner

freeranger commented Oct 29, 2017

Thanks @justinchen - Have you tested that the demo site still works, or does that need a PR also?
https://github.com/freeranger/react-bootstrap-tabs-demo

@justinchen
Copy link
Contributor Author

@freeranger I just confirmed the demo works once you add the prop-types package.

@freeranger
Copy link
Owner

Thanks @justinchen.
I just tried to npm install locally so I can test out the change and I am getting:
ReferenceError: Unknown plugin "'transform-es2015-modules-umd'" specified in "base" at 0, attempted to resolve relative to "src"
I don't know if this is related to your change or something in babel - I will have to investigate further.
What version of babel did you end up with when you did npm install?

@justinchen
Copy link
Contributor Author

@freeranger It grabbed 6.26.0 for me.

@freeranger
Copy link
Owner

@justinchen ok thanks. I was using an unfamiliar machine - I will try again at the weekend from my regular dev box..

@freeranger freeranger merged commit 73295cd into freeranger:master Nov 5, 2017
@freeranger
Copy link
Owner

Thanks @justinchen - all merged in now.

@justinchen
Copy link
Contributor Author

@freeranger great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants