bgpd: move debug vnc commands under debug rfapi-dev subnode #168
Conversation
pguibert6WIND
force-pushed
the
vnc_debug_fix_1
branch
from
30d11e0
to
bcfbde6
Compare
Commands in charge of adding prefixes to VNE is moved from global configuration node to debug rfapi-dev sub command in global configuration node. This commit handles move of vty commands for add vnc and add vrf commands. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
When creating a vrf-policy, the route distinguisher configured takes AF_UNSPEC family value, which is 0 value, whereas the len value is set to 64. This latter value it used by add vrf prefix command to check that rd is configured or not. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pguibert6WIND
force-pushed
the
vnc_debug_fix_1
branch
from
bcfbde6
to
bfebfe9
Compare
|
it also fixes the following: ubuntu1404# add vrf 10:11 prefix 1.2.3.0/24 |
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-215/ This is a comment from an EXPERIMENTAL automated CI system. |
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-217/ This is a comment from an EXPERIMENTAL automated CI system. |
|
Following command:
Must Not be kept on global config node |
|
Why?
…On February 6, 2017 6:40:24 AM Philippe Guibert ***@***.***> wrote:
Following command:
- add vnc
- add vrf
Must Not be kept on global config node
Proposal here : move to débug rfapi-dev
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#168 (comment)
|
|
global configuration mode must not be used for configuration. |
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-216/ This is a comment from an EXPERIMENTAL automated CI system. |
1 similar comment
Continous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-216/ This is a comment from an EXPERIMENTAL automated CI system. |
|
These commands aren't in config mode - they are privileged level commands.
…On 2/7/2017 4:00 AM, Philippe Guibert wrote:
global configuration mode must not be used for configuration.
global configuration mode is reserved for exploitation and debug purposes
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#168 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGRWyH5W9Knqi2jGXmF5DLGTEjF3U1wwks5raDLAgaJpZM4L352b>.
|
|
Philippe to think about this issue some more |
|
I understand some clear command or some show commands are privilege mode, that is to say not authorized to everybody. For all configuration, it is important to be able to keep the network configuration after a save running-config. If i execute add vnc command, it will not appear in show running, right ? This is the problem here. |
|
On February 9, 2017 3:50:20 AM Philippe Guibert ***@***.***> wrote:
I understand some clear command or some show commands are privilege mode,
that is to say not authorized to everybody.
The fact is that the add vrf or add vnc command is related to configuration.
It creates runtime state, not configuration.
It creates entries , like it can be done when you configure a network
prefix under address-family node.
For all configuration, it is important to be able to keep the network
configuration after a save running-config. If i execute add vnc command, it
will not appear in show running, right ?
Correct, just like routes learned from routing protocols.
This is the problem here.
maybe we can close the issue, but I really would like proposals for RD/RT
document, making it possible to configure vrf entries in configure mode.
This is different /added functionality and can be included in the
discussion. I believe it's there in the current proposal (but not code) -
but this can be discussed.
Propose a time to meet on the list. ..
Lou
…
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#168 (comment)
|
There was a problem hiding this comment.
Per earlier comments, I believe this change should not be made. @pguibert6WIND if you agree, please close this PR.
Commands in charge of adding prefixes to VNE is moved from global
configuration node to debug rfapi-dev sub command in global
configuration node.
Signed-off-by: Philippe Guibert philippe.guibert@6wind.com