Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for V1 and V2. #40

Merged
merged 8 commits into from
Sep 20, 2022
Merged

Remove code for V1 and V2. #40

merged 8 commits into from
Sep 20, 2022

Conversation

fr33r
Copy link
Contributor

@fr33r fr33r commented Jan 4, 2021

Description

Removes the code responsible for supporting V1 / V2 of the package.

Rationale

With the introduction of V4, these versions are now in unsupported territory. These versions did not support Go modules, as well as critical features introduced in V3. In order to combat the growing code size of the repository, and to encourage consumers to leverage the latest version, V1 / V2 are being officially removed.

Suggested Version

N/A

Example Usage

N/A

@fr33r fr33r self-assigned this Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 96.85% // Head: 96.45% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (9a4d940) compared to base (9f035cb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   96.85%   96.45%   -0.41%     
==========================================
  Files          20       13       -7     
  Lines        1716     1296     -420     
==========================================
- Hits         1662     1250     -412     
+ Misses         40       34       -6     
+ Partials       14       12       -2     
Flag Coverage Δ
v1 ?
v3 98.71% <ø> (ø)
v4 94.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fr33r
Copy link
Contributor Author

fr33r commented Sep 20, 2022

Release tags for v1.0.0 - v2.0.1 will forever remain in case any users wish to retrieve those old versions.

@fr33r fr33r merged commit 655d065 into master Sep 20, 2022
@fr33r fr33r deleted the freer/remove-v1-and-v2 branch September 20, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant