Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes macro implementation #13

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Removes macro implementation #13

merged 1 commit into from
Jun 22, 2017

Conversation

fedefernandez
Copy link
Contributor

This PR fixes #8 by removing the current macro. There are some reasons for that:

  • The macro is not compatible with scalameta
  • It's using a blocking call here
  • It's hard to maintain

@raulraja what do you think? Could you please review? Thanks

@codecov-io
Copy link

Codecov Report

Merging #13 into master will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #13     +/-   ##
=========================================
- Coverage    84.9%   84.31%   -0.6%     
=========================================
  Files           4        2      -2     
  Lines          53       51      -2     
=========================================
- Hits           45       43      -2     
  Misses          8        8
Impacted Files Coverage Δ
...in/scala/freestyle/cassandra/api/LowLevelAPI.scala

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7fc45...ca2e16c. Read the comment docs.

@fedefernandez fedefernandez merged commit 9afd4cd into master Jun 22, 2017
@fedefernandez fedefernandez deleted the ff-removes-macro branch June 22, 2017 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate macros to Scala meta
3 participants