Adds log4s logging to free and tagless #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
approved these changes
Jan 16, 2018
|
Could you take a look at the documentation file @MaureenElsberry ? This is the document with my changes https://github.com/frees-io/freestyle/pull/512/files#diff-081d1cdca5458a4fb00271d9fc16c23f Thanks |
fedefernandez
approved these changes
Jan 16, 2018
diesalbla
approved these changes
Jan 16, 2018
| * limitations under the License. | ||
| */ | ||
|
|
||
| package freestyle.free |
There was a problem hiding this comment.
I am not much in favor of having multiple package declarations. IMHO, an import should be as explicit and restricted as reasonably possible. In this case, it is not needed.
There was a problem hiding this comment.
Makes sense. Changed.
diesalbla
reviewed
Jan 16, 2018
| * limitations under the License. | ||
| */ | ||
|
|
||
| package freestyle.tagless |
There was a problem hiding this comment.
Makes sense. Changed.
You could use either both, depending on your requirements, and the usage would be quite similar. You could use either, or both, depending on your requirements, and the usage would be quite similar. If that is not accurate, just take out the or both and change to: You could use either, depending on your requirements, and the usage would be quite similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new way to log the messages through
log4s.I added this logger to
freeandtagless.This change doesn't have a breaking change because the default implicit
freestyle.free.loggingJVM.implicitspoint tojournaldirectly.This PR is in WIP because I want a first code review and if it adapts to your thoughts, I will update the documentation with these changes.