-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.2.2 #25
Release 0.2.2 #25
Conversation
@@ -12,7 +12,7 @@ lazy val `sbt-freestyle` = project | |||
.in(file(".")) | |||
.settings(name := "sbt-freestyle") | |||
.settings(Seq( | |||
addSbtPlugin("com.47deg" % "sbt-org-policies" % "0.7.2"), | |||
addSbtPlugin("com.47deg" % "sbt-org-policies" % "0.7.5"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fond of having to change the version number in 2 different places. Thoughts on having a similar syntax(as dependencies) for sbt plugins?
Something like:
%("sbt-org-policies")
, addSbtPlugin(%("sbt-org-policies")
, or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
I'm good with addSbtPlugin(%("sbt-org-policies")
, since %
or %%
returns the ModuleID you want to use (as a plugin or standard dependency), makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Currently %
and %%
only look for libraries(not sbt-plugins).
I'm leaning towards adding another parameter isSbtPlugin: Boolean = false
to the %
and %%
functions and switching between libs
or allPlugins
based on it.
https://github.com/47deg/sbt-org-policies/blob/master/src/main/scala/sbtorgpolicies/settings/dependencies.scala#L58
https://github.com/47deg/sbt-org-policies/blob/master/core/src/main/scala/sbtorgpolicies/libraries.scala#L327
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
No description provided.