Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom domain with knowledge base module does not work due to missing Access-Control-Allow-Origin #2287

Closed
nebulade opened this issue Sep 28, 2022 · 4 comments

Comments

@nebulade
Copy link
Contributor

Initially reported at https://forum.cloudron.io/topic/7702/fyi-knowledge-base-custom-domains which already has some context.
So when a custom domain is set for the knowledge base, the Access-Control-Allow-Origin headers are not sent from the main domain. This affects at least the fonts.

One solution is to set those headers accordingly or maybe all resources should be fetched using the custom knowledgebase origin.

@freescout-helpdesk
Copy link
Contributor

freescout-helpdesk commented Sep 30, 2022

We've checked - when Knowledge Base is opened on a custom domain all CSS files are loaded from the custom domain too, including fonts CSS: https://demo.freescout.net/css/fonts.css

And fonts CSS have file relative paths to fonts (../../fonts/liberation-sans/LiberationSans-Bold-webfont.eot), so there should be no problems with fonts being requested from another domain.

@freescout-helpdesk
Copy link
Contributor

We've reproduced it. It works fine with APP_ENV=local but not in production environment.

@freescout-helpdesk
Copy link
Contributor

Fixed in Knowledge Base Module v1.0.38

@nebulade
Copy link
Contributor Author

Thanks! I can confirm this is working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants