New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests, charlie): Add menu translation keys #6134
base: develop
Are you sure you want to change the base?
fix(tests, charlie): Add menu translation keys #6134
Conversation
Someone is attempting to deploy a commit to the freesewing Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6134 +/- ##
========================================
Coverage 97.21% 97.21%
========================================
Files 15 15
Lines 4493 4493
Branches 535 535
========================================
Hits 4368 4368
Misses 122 122
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm thinking that using the string Or, perhaps there might be a better way to provide menu translations for designs? |
Reworking this PR to not use the "o" section in the i18n json files. |
Didn't see this comment earlier but I appreciate the effort |
I am still working on this PR, though I've been sidetracked the past few weeks. |
This PR includes a change to the design i18n tests to allow design menu translation keys. If
o.<key>.d
is set tomenu
, it means that the item is menu name and not an actual option. This causes the test to check for an actual option to be skipped.So, to add a translation key for a menu:
This PR also adds 3 menu translations for Charlie.