Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace input type="number" with input type="text" inputmode="numeric"/"decimal" #6763

Merged
merged 1 commit into from
May 15, 2024

Conversation

HaasJona
Copy link
Contributor

Fixes #6542

Also fixes some other small issues:

  • duplicate item_number input element in patron Paypal code
  • replaced invalid inputMode="number" with inputMode="decimal"
  • replaced disabled={Number(amount) < 1} with disabled={!(Number(amount) > 0)} (an invalid value would be NaN, which wouldn't be less than 1.)

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
freesewing-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 8:13am

Copy link

vercel bot commented May 15, 2024

@HaasJona is attempting to deploy a commit to the freesewing Team on Vercel.

A member of the Team first needs to authorize it.

@HaasJona HaasJona changed the title Replace input type="number" with input type="numeric"/"decimal" Replace input type="number" with input type="text" inputmode="numeric"/"decimal" May 15, 2024
Copy link
Member

@joostdecock joostdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@joostdecock joostdecock merged commit d62e5e1 into freesewing:develop May 15, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Change input type for number fields
2 participants