Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.13.4: test suite is failing #89

Closed
kloczek opened this issue Sep 2, 2021 · 9 comments
Closed

1.13.4: test suite is failing #89

kloczek opened this issue Sep 2, 2021 · 9 comments

Comments

@kloczek
Copy link

kloczek commented Sep 2, 2021

Source tree configured with:

%configure \
        --disable-rpath \
        --disable-static \
        --disable-stun \
        --with-doxygen \

and test suite is failing with:

==============================================================
   sofia-sip 1.13.4: libsofia-sip-ua/sresolv/test-suite.log
==============================================================

# TOTAL: 3
# PASS:  1
# SKIP:  1
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: check_sres_sip
====================

Running suite(s): Unit tests for SIP URI resolver
89%: Checks: 19, Failures: 2, Errors: 0
check_sres_sip.c:809:F:1 - Test simple resolving:found_naptr3:0: Failure 'ai->ai_protocol != TPPROTO_TCP' occurred
check_sres_sip.c:901:F:1 - Test simple resolving:found_srv:0: Failure 'ai->ai_protocol != TPPROTO_TCP' occurred
FAIL check_sres_sip (exit status: 1)

SKIP: run_test_sresolv
======================

./run_test_sresolv: line 59: type: named: not found
test_sresolv: there is no BIND 9 named in you path, skipping
SKIP run_test_sresolv (exit status: 77)

============================================================================
Testsuite summary for sofia-sip 1.13.4
============================================================================
# TOTAL: 3
# PASS:  1
# SKIP:  1
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See libsofia-sip-ua/sresolv/test-suite.log
============================================================================
make[4]: *** [Makefile:931: test-suite.log] Error 1
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.4/libsofia-sip-ua/sresolv'
make[3]: *** [Makefile:1039: check-TESTS] Error 2
make[2]: *** [Makefile:1127: check-am] Error 2
make[1]: *** [Makefile:613: check-recursive] Error 1

Please let me know if you need more details.

@kloczek
Copy link
Author

kloczek commented Jul 13, 2022

Tested that commit and test suite still is failing

FAIL: test_soa
==============

test_soa.c:2156: test_soa test_address_in_offer() FAILED: c->c_addrtype != c_addrtype or 2 != 1
test_soa.c:2247: test_soa test_address_selection() FAILED: test_address_in_offer(a, "11.12.13.14", sdp_addr_ip4, "11.12.13.14", sdp_addr_ip4) != 0 or 1 != 0
test_soa.c:955: test_soa test_codec_selection() FAILED: rm->rm_pt != 96 or 97 != 96
FAIL test_soa (exit status: 1)

============================================================================
Testsuite summary for sofia-sip 1.13.8
============================================================================
# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See libsofia-sip-ua/soa/test-suite.log
============================================================================

@kloczek
Copy link
Author

kloczek commented Jul 13, 2022

BTW it would be really good to spend some time on fixing compile time warnings

[tkloczko@devel-g2v SPECS]$ rpmbuild -ba --with check --with failing_tests sofia-sip.spec --quiet 2>&1 | grep -- \\[-W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
   3591 -Wmisleading-indentation
     21 -Warray-parameter=
     11 -Wunused-but-set-variable
      7 -Wunused-value
      7 -Wdeprecated-declarations
      4 -Waddress
      2 -Wsequence-point
      1 -Wunused-variable
      1 -Wsizeof-pointer-memaccess
      1 -Wlto-type-mismatch
      1 -Wincompatible-pointer-types
      1 -Wdiscarded-qualifiers

@kloczek
Copy link
Author

kloczek commented Jul 14, 2022

gentle ping 😋

@mattst88
Copy link
Contributor

See #135

@kloczek
Copy link
Author

kloczek commented Jul 21, 2022

Just tested that PR and looks like test suite is filing now on linking

============================================================================
Testsuite summary for sofia-sip 1.13.8
============================================================================
# TOTAL: 1
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[5]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/tport'
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/tport'
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/tport'
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/tport'
Making check in nta
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nta'
make  check-am
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nta'
make  check_nta test_nta_api test_nta portbind
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nta'
         LINK check_nta
/usr/bin/ld: cannot find -lz: No such file or directory
collect2: error: ld returned 1 exit status
make[4]: *** [Makefile:852: check_nta] Error 1
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nta'
make[3]: *** [Makefile:1192: check-am] Error 2
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nta'
make[2]: *** [Makefile:1195: check] Error 2
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nta'
make[1]: *** [Makefile:615: check-recursive] Error 1
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua'
make: *** [Makefile:508: check-recursive] Error 1

In other words there is missing zlib depenency checking.

@kloczek
Copy link
Author

kloczek commented Jul 21, 2022

I think that below pattch should fix the issue

--- a/configure.ac
+++ b/configure.ac
@@ -255,10 +255,7 @@
 AC_CHECK_HEADERS([fnmatch.h])

 AC_CHECK_LIB(pthread, pthread_setschedparam, [AC_DEFINE(HAVE_PTHREAD_SETSCHEDPARAM, 1, [Define if you have pthread_setschedparam()])])
-AC_CHECK_LIB(z, compress, [have_zlib=yes],[have_zlib=no])
-if test x"$have_zlib" = "xyes"; then
-   AC_DEFINE(HAVE_ZLIB_COMPRESS, 1, [Define if you have zlib compress])
-fi
+PKG_CHECK_MODULES(ZLIB, [zlib], [have_zlib=yes],[have_zlib=no])
 AM_CONDITIONAL([HAVE_ZLIB], [test "x$have_zlib" = xyes])

 dnl dl is currently used only in testing
--- a/libsofia-sip-ua/nta/Makefile.am
+++ b/libsofia-sip-ua/nta/Makefile.am
@@ -61,7 +62,8 @@
                        ../msg/libmsg.la \
                        ../bnf/libbnf.la \
                        ../su/libsu.la \
-                       ${top_builddir}/s2check/libs2.a -lz
+                       ${top_builddir}/s2check/libs2.a \
+                       $(ZLIB_LIBS)

 test_nta_LDFLAGS =     -static

--- a/libsofia-sip-ua/nua/Makefile.am
+++ b/libsofia-sip-ua/nua/Makefile.am
@@ -52,7 +52,8 @@
                        check_etsi.c check_simple.c

 check_nua_LDADD =      $(nua_libs) ${top_builddir}/s2check/libs2.a \
-                       @CHECK_LIBS@ -lz
+                       @CHECK_LIBS@ \
+                       $(ZLIB_LIBS)

 nua_libs =             libnua.la  \
                        ../iptsec/libiptsec.la \
--- a/libsofia-sip-ua/stun/Makefile.am
+++ b/libsofia-sip-ua/stun/Makefile.am
@@ -14,7 +14,6 @@
 # Header paths

 AM_CPPFLAGS =          $(INTERNAL_INCLUDES)
-LD_FLAGS = -lz

 # ----------------------------------------------------------------------
 # Build targets
@@ -39,7 +38,10 @@

 COVERAGE_INPUT =       $(libstun_la_SOURCES) $(include_sofia_HEADERS)

-LDADD =                libstun.la ../sresolv/libsresolv.la ../su/libsu.la
+LDADD =                libstun.la \
+                       ../sresolv/libsresolv.la \
+                       ../su/libsu.la \
+                       $(ZLIB_LIBS)

 # ----------------------------------------------------------------------
 # tests
--- a/libsofia-sip-ua/Makefile.am
+++ b/libsofia-sip-ua/Makefile.am
@@ -59,10 +59,7 @@
 # - soname to 'libsofia-sip-ua.so.(CUR-AGE)'
 libsofia_sip_ua_la_LDFLAGS = \
        -version-info $(LIBVER_SOFIA_SIP_UA_CUR):$(LIBVER_SOFIA_SIP_UA_REV):$(LIBVER_SOFIA_SIP_UA_AGE)
-
-if HAVE_ZLIB
-libsofia_sip_ua_la_LDFLAGS += -lz
-endif
+libsofia_sip_ua_la_LIBS = $(ZLIB_LIBS)

 PHONY = doxygen built-sources

@kloczek
Copy link
Author

kloczek commented Jul 21, 2022

Now looks like test suite fails because some taileouts

============================================================================
make[5]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/iptsec'
Making check in nua
/usr/bin/make  check-am
/usr/bin/make  check_nua
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
         COMPILE check_etsi.o
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
         COMPILE check_nua.o
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
         COMPILE check_register.o
check_register.c: In function 'register_1_0_1_fn':
check_register.c:124:3: warning: too many arguments for format [-Wformat-extra-args]
  124 |   fail_unless((m = s2_sip_wait_for_request(SIP_METHOD_REGISTER)) != NULL, NULL);
      |   ^~~~~~~~~~~
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
         COMPILE check_simple.o
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
         COMPILE check_session.o
check_session.c: In function 'call_2_4_5_fn':
check_session.c:1505:25: warning: variable 'branch2' set but not used [-Wunused-but-set-variable]
 1505 |   sip_from_t *branch1, *branch2;
      |                         ^~~~~~~
check_session.c:1505:15: warning: variable 'branch1' set but not used [-Wunused-but-set-variable]
 1505 |   sip_from_t *branch1, *branch2;
      |               ^~~~~~~
check_session.c: In function 'refer_5_2_1_fn':
check_session.c:3495:17: warning: variable 'refer' set but not used [-Wunused-but-set-variable]
 3495 |   struct event *refer;
      |                 ^~~~~
check_session.c: In function 'refer_5_2_2_fn':
check_session.c:3527:25: warning: variable 'notified' set but not used [-Wunused-but-set-variable]
 3527 |   struct event *refer, *notified;
      |                         ^~~~~~~~
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
         LINK check_nua
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
/usr/bin/make  check-TESTS

make[5]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
FAIL: check_nua
make[5]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
make[5]: Entering directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
==========================================================
   sofia-sip 1.13.8: libsofia-sip-ua/nua/test-suite.log
==========================================================

# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: check_nua
===============

Running suite(s): Unit tests for Sofia-SIP UA Engine
5%: Checks: 192, Failures: 0, Errors: 182
check_register.c:115:E:1 - REGISTER:register_1_0_1:0: (after this point) Test timeout expired
check_register.c:136:E:1 - REGISTER:register_1_1_1:0: (after this point) Test timeout expired
check_register.c:147:E:1 - REGISTER:register_1_1_2:0: (after this point) Test timeout expired
check_register.c:230:E:1 - REGISTER:register_1_2_1:0: (after this point) Test timeout expired
check_register.c:331:E:1 - REGISTER:register_1_2_2_1:0: (after this point) Test timeout expired
check_register.c:348:E:1 - REGISTER:register_1_2_2_2:0: (after this point) Test timeout expired
check_register.c:427:E:1 - REGISTER:register_1_2_2_3:0: (after this point) Test timeout expired
check_register.c:482:E:1 - REGISTER:register_1_2_3:0: (after this point) Test timeout expired
check_register.c:979:E:1.4 - REGISTER server:registrar_1_4_1:0: (after this point) Test timeout expired
check_simple.c:70:S:6.1 - Basic SUBSCRIBE_:subscribe_6_1_1:0: (after this point) Test timeout expired
check_simple.c:70:S:6.1 - Basic SUBSCRIBE_:subscribe_6_1_2:0: (after this point) Test timeout expired
check_simple.c:70:S:6.1 - Basic SUBSCRIBE_:subscribe_6_1_3:0: (after this point) Test timeout expired
check_simple.c:70:S:6.1 - Basic SUBSCRIBE_:subscribe_6_1_4:0: (after this point) Test timeout expired
check_simple.c:70:S:6.2 - Event fetch:fetch_6_2_1:0: (after this point) Test timeout expired
check_simple.c:70:S:6.2 - Event fetch:fetch_6_2_2:0: (after this point) Test timeout expired
check_simple.c:70:S:6.2 - Event fetch:fetch_6_2_3:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_1:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_2:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_3:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_4:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_5:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_2_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_3_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_3_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_4:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_5:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_6:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_7:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_8:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_3:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_4:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_6:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_7:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_8:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_9:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_10:0: (after this point) Test timeout expired
check_session.c:80:S:2.3 - Session timers:call_2_3_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.3 - Session timers:call_2_3_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_3:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_4:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_5:0: (after this point) Test timeout expired
check_session.c:80:S:2.5 - Call with preconditions:call_2_5_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.5 - Call with preconditions:call_2_5_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.5 - Call with preconditions:call_2_5_3:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_3:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_4:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_5:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_1_1:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_1_2:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_2_2:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_2_3:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_1:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_2:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_3:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_4:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_5:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_6:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_7:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_8:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_9:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_10:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_11:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_2_2:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_1:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_2:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_3:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_4:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_5:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_6:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_7:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_4_1:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_4_2:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_4_3_1:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_4_3_2:0: (after this point) Test timeout expired
check_session.c:80:S:5 - OPTIONS, etc:options_5_1_1:0: (after this point) Test timeout expired
check_session.c:80:S:5 - OPTIONS, etc:options_5_1_2:0: (after this point) Test timeout expired
check_session.c:80:S:5.2 - Call Transfer:refer_5_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:5.2 - Call Transfer:refer_5_2_2:0: (after this point) Test timeout expired
check_etsi.c:169:E:6.1 - ETSI CC OE - Call Establishment:SIP_CC_OE_CE_V_019:0: (after this point) Test timeout expired
check_etsi.c:169:E:6.1 - ETSI CC OE - Call Establishment:SIP_CC_OE_CE_TI_008:0: (after this point) Test timeout expired
check_etsi.c:169:E:6.1 - ETSI CC OE - Call Establishment:SIP_CC_OE_CE_TI_011_012:0: (after this point) Test timeout expired
check_register.c:115:E:1 - REGISTER:register_1_0_1:0: (after this point) Test timeout expired
check_register.c:136:E:1 - REGISTER:register_1_1_1:0: (after this point) Test timeout expired
check_register.c:147:E:1 - REGISTER:register_1_1_2:0: (after this point) Test timeout expired
check_register.c:230:E:1 - REGISTER:register_1_2_1:0: (after this point) Test timeout expired
check_register.c:331:E:1 - REGISTER:register_1_2_2_1:0: (after this point) Test timeout expired
check_register.c:348:E:1 - REGISTER:register_1_2_2_2:0: (after this point) Test timeout expired
check_register.c:427:E:1 - REGISTER:register_1_2_2_3:0: (after this point) Test timeout expired
check_register.c:482:E:1 - REGISTER:register_1_2_3:0: (after this point) Test timeout expired
check_register.c:1001:E:1.4 - REGISTER server:registrar_1_4_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_2_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_3_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_3_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_4:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_5:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_6:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_7:0: (after this point) Test timeout expired
check_session.c:80:S:2.1 - Basic INVITE:call_2_1_8:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_3:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_4:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_6:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_7:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_8:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_9:0: (after this point) Test timeout expired
check_session.c:80:S:2.2 - CANCEL:cancel_2_2_10:0: (after this point) Test timeout expired
check_session.c:80:S:2.3 - Session timers:call_2_3_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.3 - Session timers:call_2_3_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_3:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_4:0: (after this point) Test timeout expired
check_session.c:80:S:2.4 - INVITE with 100rel:call_2_4_5:0: (after this point) Test timeout expired
check_session.c:80:S:2.5 - Call with preconditions:call_2_5_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.5 - Call with preconditions:call_2_5_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.5 - Call with preconditions:call_2_5_3:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_1:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_2:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_3:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_4:0: (after this point) Test timeout expired
check_session.c:80:S:2.6 - re-INVITEs:call_2_6_5:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_1_1:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_1_2:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_2_2:0: (after this point) Test timeout expired
check_session.c:80:S:3 - Call Errors:call_3_2_3:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_1:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_2:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_3:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_4:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_5:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_6:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_7:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_8:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_9:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_10:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_1_11:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:4 - Call Termination:bye_4_2_2:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_1:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_2:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_3:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_4:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_5:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_6:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_3_7:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_4_1:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_4_2:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_4_3_1:0: (after this point) Test timeout expired
check_session.c:80:S:4.3 - Destroying Handle:destroy_4_4_3_2:0: (after this point) Test timeout expired
check_session.c:80:S:5 - OPTIONS, etc:options_5_1_1:0: (after this point) Test timeout expired
check_session.c:80:S:5 - OPTIONS, etc:options_5_1_2:0: (after this point) Test timeout expired
check_session.c:80:S:5.2 - Call Transfer:refer_5_2_1:0: (after this point) Test timeout expired
check_session.c:80:S:5.2 - Call Transfer:refer_5_2_2:0: (after this point) Test timeout expired
check_etsi.c:169:E:6.1 - ETSI CC OE - Call Establishment:SIP_CC_OE_CE_V_019:0: (after this point) Test timeout expired
check_etsi.c:169:E:6.1 - ETSI CC OE - Call Establishment:SIP_CC_OE_CE_TI_008:0: (after this point) Test timeout expired
check_etsi.c:169:E:6.1 - ETSI CC OE - Call Establishment:SIP_CC_OE_CE_TI_011_012:0: (after this point) Test timeout expired
check_simple.c:70:S:6.1 - Basic SUBSCRIBE_:subscribe_6_1_1:0: (after this point) Test timeout expired
check_simple.c:70:S:6.1 - Basic SUBSCRIBE_:subscribe_6_1_2:0: (after this point) Test timeout expired
check_simple.c:70:S:6.1 - Basic SUBSCRIBE_:subscribe_6_1_3:0: (after this point) Test timeout expired
check_simple.c:70:S:6.1 - Basic SUBSCRIBE_:subscribe_6_1_4:0: (after this point) Test timeout expired
check_simple.c:70:S:6.2 - Event fetch:fetch_6_2_1:0: (after this point) Test timeout expired
check_simple.c:70:S:6.2 - Event fetch:fetch_6_2_2:0: (after this point) Test timeout expired
check_simple.c:70:S:6.2 - Event fetch:fetch_6_2_3:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_1:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_2:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_3:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_4:0: (after this point) Test timeout expired
check_simple.c:70:S:6.3 - Basic event server with NOTIFY :notify_6_3_5:0: (after this point) Test timeout expired
FAIL check_nua (exit status: 1)

============================================================================
Testsuite summary for sofia-sip 1.13.8
============================================================================
# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See libsofia-sip-ua/nua/test-suite.log
============================================================================
make[5]: *** [Makefile:965: test-suite.log] Error 1
make[5]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/sofia-sip-1.13.8/libsofia-sip-ua/nua'
make[4]: *** [Makefile:1073: check-TESTS] Error 2
make[3]: *** [Makefile:1146: check-am] Error 2
make[2]: *** [Makefile:1148: check] Error 2
make[1]: *** [Makefile:617: check-recursive] Error 1
make: *** [Makefile:510: check-recursive] Error 1

@mattst88
Copy link
Contributor

I think it's best to file issues for specific problems, instead of a single issue for "the test suite is failing".

@kloczek kloczek changed the title 1.13.4: test suite is failin 1.13.4: test suite is failing Jul 22, 2022
@kloczek
Copy link
Author

kloczek commented Jan 18, 2023

Do you want me to submit that zlib patch as PR?

minhtuan1407-telnyx pushed a commit to team-telnyx/sofia-sip that referenced this issue Jul 19, 2023
* Fix misleading indentation

* Fix -Wunused-value warnings

torture_sresolv.c:342:13: warning: right-hand operand of comma expression has no effect [-Wunused-value]
  342 |   for (i = 0, N; i < N; i++)
      |             ^

* Fix -Wunused-value warnings

stun_internal.h:90:66: warning: right-hand operand of comma expression has no effect [-Wunused-value]
   90 |   SU_DEBUG_5(("%s: %s: %s\n", __func__, #what, su_strerror(err))), \
      |                                                                  ^
stun.c:1318:5: note: in expansion of macro ‘STUN_ERROR’
 1318 |     STUN_ERROR(one, SO_ERROR);
      |     ^~~~~~~~~~

* Remove unused variables

torture_sresolv.c: In function ‘test_api_errors’:
torture_sresolv.c:142:7: warning: variable ‘s’ set but not used [-Wunused-but-set-variable]
  142 |   int s, fd;
      |       ^
torture_sresolv.c:177:5: warning: ‘sockets’ may be used uninitialized [-Wmaybe-uninitialized]
  177 |   s = sockets[0];
      |   ~~^~~~~~~~~~~~
torture_sresolv.c:143:7: note: ‘sockets’ declared here
  143 |   int sockets[20];
      |       ^~~~~~~

* Fix pointer memaccess warning

test_sresolv.c: In function ‘test_deinit’:
test_sresolv.c:1875:25: warning: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
 1875 |   memset(ctx, 0, sizeof ctx);
      |                         ^~~

* Remove unused function

test_sresolv.c: In function ‘fill_stack’:
test_sresolv.c:1920:9: warning: variable ‘array’ set but not used [-Wunused-but-set-variable]
 1920 |   int i,array[32768];
      |         ^~~~~

* Fix sequence point warning

test_memmem.c: In function ‘test_notfound’:
test_memmem.c:97:19: warning: operation on ‘a’ may be undefined [-Wsequence-point]
   97 |   TEST_P(memmem(a = "a\0bc", 4, "a\0bc", 4), a);
      |                 ~~^~~~~~~~~

* Fix set but unused warnings

su_proxy.c: In function ‘forwarder_accept’:
su_proxy.c:361:7: warning: variable ‘events’ set but not used [-Wunused-but-set-variable]
  361 |   int events;
      |       ^~~~~~

* Fix buffer size warning

torture_url.c: In function ‘test_sip’:
torture_url.c:368:45: warning: ‘%s’ directive output may be truncated writing up to 511 bytes into a region of size 498 [-Wformat-truncation=]
  368 |     snprintf(pu, sizeof(pu), "sip:test@host;%s", param);
      |                                             ^~   ~~~~~
torture_url.c:368:5: note: ‘snprintf’ output between 15 and 526 bytes into a destination of size 512
  368 |     snprintf(pu, sizeof(pu), "sip:test@host;%s", param);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

* Use memmove for overlapping src and destination

In file included from /usr/include/string.h:519,
                 from stun.c:41:
In function ‘memcpy’,
    inlined from ‘stun_test_nattype’ at stun.c:1251:5:
/usr/include/bits/string_fortified.h:29:10: warning: ‘__builtin_memcpy’ accessing 32 bytes at offsets 96 and 72 overlaps 8 bytes at offset 96 [-Wrestrict]
   29 |   return __builtin___memcpy_chk (__dest, __src, __len,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   30 |                                  __glibc_objsize0 (__dest));
      |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘memcpy’,
    inlined from ‘stun_test_lifetime’ at stun.c:2740:5:
/usr/include/bits/string_fortified.h:29:10: warning: ‘__builtin_memcpy’ accessing 32 bytes at offsets 96 and 72 overlaps 8 bytes at offset 96 [-Wrestrict]
   29 |   return __builtin___memcpy_chk (__dest, __src, __len,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   30 |                                  __glibc_objsize0 (__dest));
      |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~

* Fix array size

check_sres_sip.c: In function ‘resolver_setup’:
check_sres_sip.c:113:19: warning: array subscript 2 is above array bounds of ‘su_addrinfo_t[2]’ {aka ‘struct addrinfo[2]’} [-Warray-bounds]
  113 |   hint_udp_tcp_tls[2].ai_protocol = TPPROTO_TLS;
      |   ~~~~~~~~~~~~~~~~^~~
check_sres_sip.c:69:22: note: while referencing ‘hint_udp_tcp_tls’
   69 | static su_addrinfo_t hint_udp_tcp_tls[2];
      |                      ^~~~~~~~~~~~~~~~
check_sres_sip.c:114:19: warning: array subscript 2 is above array bounds of ‘su_addrinfo_t[2]’ {aka ‘struct addrinfo[2]’} [-Warray-bounds]
  114 |   hint_udp_tcp_tls[2].ai_next = NULL;
      |   ~~~~~~~~~~~~~~~~^~~
check_sres_sip.c:69:22: note: while referencing ‘hint_udp_tcp_tls’
   69 | static su_addrinfo_t hint_udp_tcp_tls[2];
      |                      ^~~~~~~~~~~~~~~~

Fixes: freeswitch#89

* Enable scan-build-11 on Drone CI

* Scan-build: Fix false positive Memory error Use-after-free libsofia-sip-ua/su/su_timer.c timers_is_full (freeswitch#136)

* Scan-build: Fix Dead store Dead nested assignment libsofia-sip-ua/msg/msg_mime.c msg_multipart_parse

* Scan-build: Fix Dead store Dead nested assignment libsofia-sip-ua/msg/msg_mime.c msg_multipart_parse

* Scan-build: Fix Dead store Dead nested assignment libsofia-sip-ua/msg/msg_mime.c msg_multipart_parse

* Scan-build: Fix Dead store Dead nested assignment libsofia-sip-ua/msg/msg_parser_util.c msg_avlist_d

* Scan-build: Fix Dead store  Dead nested assignment  libsofia-sip-ua/sresolv/sres.c  sres_resolver_error

* Scan-build: Fix  Dead store  Dead nested assignment  libsofia-sip-ua/nta/sl_read_payload.c  sl_read_payload

* Scan-build: Fix Dead store Dead nested assignment libsofia-sip-ua/nua/nua_session.c

* Scan-build: Fix Dead store  Dead nested assignment  libsofia-sip-ua/sresolv/sres.c

* Scan-build: Fix Dead store Dead nested assignment  libsofia-sip-ua/http/http_parser.c  http_extract_chunk

* Scan-build: Fix Dead store  Dead nested assignment libsofia-sip-ua/sresolv/sres_sip.c

* Scan-build: Fix Dead store  Dead nested assignment

* Scan-build: Fix Dereference of null pointer

* Scan-build: Fix Logic error  Return of address to stack-allocated memory  libsofia-sip-ua/sresolv/sres.c   sres_create_record

* Scan-build: Fix Logic error Result of operation is garbage or undefined

* Scan-build: Fix Logic error Array subscript is undefined libsofia-sip-ua/bnf/sofia-sip/bnf.h span_unreserved

* Fix typo made by previous commit to su_select_port.c

* remove closed secondary transports from pri_closed in case of transport errors too

* Add TPTAG_CAPT_SRC to optionally set specify IP to report to HEP/EEP

* Version bump to 1.13.9

* Fix crash when certificate file is not accessible

* sdp_parse.c: allow msgsize = -1 in sdp_parse() arguments

MeeGo Coverity issue CID#7514

* Fix SSL shutdown

* Disable some tests.

* stun: add checks for STUN messag len and attr len

Signed-off-by: Qiuhao Li <Qiuhao.Li@outlook.com>

* Fix check of poll result in sresolv

* Version bump to 1.13.10

* Version bump to 1.13.11

* Add new nua_nta_agent_resolver_clean_dns_cache() API.

* multiple identity headers

* array support Identity

* non-compact Identity Header

* remove strange charater in comment

* remove strange characters

* Add ws_set_global_payload_size_max() API.

* Version bump to 1.13.12

* Add GitHub Actions workflow support

* Define nua_nta_agent_resolver_clean_dns_cache() macro.

* Version bump to 1.13.13

* remove assert that can reasonably be expected to happen

* Create SECURITY.md

* Version bump to 1.13.14

* TEL-5699: Add new tag for sip timer h

---------

Signed-off-by: Qiuhao Li <Qiuhao.Li@outlook.com>
Co-authored-by: Matt Turner <mattst88@gmail.com>
Co-authored-by: Andrey Volk <andywolk@gmail.com>
Co-authored-by: root <prabhu.swamynathan@ecosmob.com>
Co-authored-by: prabhugithubme <100773071+prabhugithubme@users.noreply.github.com>
Co-authored-by: Flavio Grossi <flaviogrossi@gmail.com>
Co-authored-by: Chris Rienzo <chris@signalwire.com>
Co-authored-by: Jakub Karolczyk <jakub.karolczyk@signalwire.com>
Co-authored-by: Pekka Pessi <Pekka.Pessi@nokia.com>
Co-authored-by: Qiuhao Li <Qiuhao.Li@outlook.com>
Co-authored-by: Giacomo Vacca <giacomo.vacca@gmail.com>
Co-authored-by: Minh <hnimminh@outlook.com>
Co-authored-by: Lucas Mellos Carlos <102970912+lucasmellos@users.noreply.github.com>
Co-authored-by: Dave Horton <daveh@beachdognet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants