Add game name to browser stream #200
Conversation
Add game name (rom) on init request to the browser stream, to allow the requester to adapt its rendering to the game.
|
To elaborate a bit more, I'm not the author of DMD overlay but like the idea. Here are examples of what you can get with this type of approach (DMD rendering, adapted to each pinball for DMD, glass and frame) ;
This allows for 2 screens setup to add an overlay on the backglass, keeping the right aspect ratio for the backglass, and cleanly integrating the whole. All of this, without bloating dmdext with each of the dmd rendering flavour we could imagine. |
|
And to be complete, I have put the example code (MIT license) for above rendering in a gist here. |
|
Cool, I didn't know people were actually using the stream. That's awesome! :) Could you reformat your changes so the code stays coherent with the rest (mainly replace spaces with tabs)? Then I'll review it! Thanks! |
Fix formatting and bug freezy#201
|
New commit fixes the formatting as well as the issue #201 |
LibDmd/DmdDevice/DmdDevice.cs
Outdated
| @@ -339,7 +339,7 @@ private void SetupGraphs() | |||
| renderers.Add(new VpdbStream { EndPoint = _config.VpdbStream.EndPoint }); | |||
| } | |||
| if (_config.BrowserStream.Enabled) { | |||
| renderers.Add(new BrowserStream(_config.BrowserStream.Port)); | |||
| renderers.Add(new BrowserStream(_gameName, _config.BrowserStream.Port)); | |||
There was a problem hiding this comment.
I would prefer this as a second, optional parameter. Reason being that while the browser stream is currently only used for DmdDevice, we might also use it for the dmdext executable, where the game name is not available.
There was a problem hiding this comment.
Request integrated in latest commit
Swap the order of parameters for BrowserStream, and made it optional. Made size message logging more clear.
Add game name (rom) on init request to the browser stream, to allow the requester to adapt its rendering to the game.
The browser stream output allow to create fancy DMD rendering. To allow skinning based on the game rom, you need to get this information from PinMame. The most clean way is for dmdext to pull it on init request, hence this small pull request. This allows little software like DMDOverlay to be more clean and simple.