Dispatch events on contentEditable elements
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably not! Your change makes sense, did you have a chance to test it? Does it fix the issue? |
|
Oh yes, it fixes Notion and doesn't break any other sites that I use 😄 |
fregante
changed the title
contentEditable elements
|
I just realized that this was never shipped. Now it's in https://github.com/fregante/GhostText/releases/tag/22.3.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was taking a look to see why Notion was not working properly and I noticed that for fields that are
contentEditable, the events are not dispatched because thecontentEditablewrapper doesn't have theelement.dispatchEventmethod bonded. Therefore, this conditional is never run.I wonder if that was on purpose or not. Notion seems to depend on the
inputevent, so it woks fine after this modification.